Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run format-text on keyboard PRs #19656

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Run format-text on keyboard PRs #19656

merged 1 commit into from
Jan 22, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 22, 2023 •
edited
Loading

Description

Should help catch issues like #19615 slipping through.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr force-pushed the feature/kb_lint_format branch 3 times, most recently from 4698bcd to a17aa83 Compare January 22, 2023 02:19
@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Jan 22, 2023
@zvecr zvecr force-pushed the feature/kb_lint_format branch from a17aa83 to b367cf1 Compare January 22, 2023 02:20
@zvecr zvecr force-pushed the feature/kb_lint_format branch from b367cf1 to 2fa4568 Compare January 22, 2023 02:22
@github-actions github-actions bot removed via Adds via keymap and/or updates keyboard for via support keymap labels Jan 22, 2023
@zvecr zvecr force-pushed the feature/kb_lint_format branch from 2fa4568 to e90d8ff Compare January 22, 2023 02:24
@zvecr zvecr removed the in progress label Jan 22, 2023
@zvecr zvecr requested a review from a team January 22, 2023 02:25
@github-actions github-actions bot removed the keyboard label Jan 22, 2023
@tzarc tzarc merged commit 603c86b into qmk:develop Jan 22, 2023
@zvecr zvecr deleted the feature/kb_lint_format branch January 22, 2023 03:18
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
Run format-text on keyboard PRs (qmk#19656)
5a7a2ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc