Add direction to dynamic_macro_record_start_user #19689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a means for user code to know which macro is being recorded, e.g., to display different indicators on an OLED.
Adds a
direction
argument todynamic_macro_record_start_user()
, just like the otherdynamic_macro_*_user()
functions.Description
Change
void dynamic_macro_record_start_user(void)
tovoid dynamic_macro_record_start_user(int8_t direction)
.direction
is either+1
or-1
to indicate which dynamic macro is being recorded, making it similar to the otherdynamic_macro_*_user()
functions (which already take adirection
).Updated keyboard code with the new function signatures, as well as the documentation.
I did not touch the deprecated
quantum/dynamic_macro.h
which has a very different API.Types of Changes
Issues Fixed or Closed by This PR
None
Checklist