Allow a larger int for the idle timeout for urbanvanilla keymap #19738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing code used a uint32_t for the idle timer, but the comparisons were done with timer_read and timer_elapsed so actual comparison was on uint16_t. This meant the idle timer could not be more than 65535 milliseconds, or just over 1 minute. Switched the comparisons to timer_read32 and timer_elapsed32 so that the largest possible timeout is 4,294,967,295ms, or 136 years. While that would be pretty ridiculous, at least this way more reasonable longer timeouts like 15 minutes or an hour will work.
drashna
approved these changes
Feb 2, 2023
zvecr
reviewed
Feb 2, 2023
There was a problem hiding this comment.
@urbanvanilla will have to sign off on the changes, otherwise the change has to go via develop (which i've updated the target to reflect this).
fauxpark
approved these changes
Feb 3, 2023
|
Clearing backlog, merging to |
coquizen
pushed a commit
to coquizen/qmk_firmware
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing code used a uint32_t for the idle timer, but the comparisons were done with timer_read and timer_elapsed so actual comparison was on uint16_t. This meant the idle timer could not be more than 65535 milliseconds, or just over 1 minute.
Switched the comparisons to timer_read32 and timer_elapsed32 so that the largest possible timeout is 4,294,967,295ms, or 136 years. While that would be pretty ridiculous, at least this way more reasonable longer timeouts like 15 minutes or an hour will work.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist