-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup] Quantum Painter #19825
[Cleanup] Quantum Painter #19825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From memory, everything struct
was QP-internal.
Guess it doesn't really matter.
SHA1's all match for all QP-enabled boards in the repo. |
What does this mean? "Everything compiles"? 😅 |
Yes, generated binaries are identical before and after this PR is applied. |
Merge conflicts here. |
Co-authored-by: Nick Brassel <nick@tzarc.org>
SHA1's still match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Description
Just some tidying of QP's codebase, adding some
typedef
s here and there to get rid of boilerplatestruct
Some of these types are defined in.c
files, i dont know if they should be moved to.h
, i also renamed a couple of them, appending_t
A couple of minor changes too
QP_MIN
__attribute__((packed))
withQP_PACKED
Tested by compiling my keyboard's files and display worked fine. Didn't test exhaustively tho
Haven't linted, as i think the changes haven't mess up formatting, im gonna let CI warn and fix offending files if any.Types of Changes
Issues Fixed or Closed by This PR
Checklist