Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64x48 oled support #19955

Closed
wants to merge 3 commits into from
Closed

64x48 oled support #19955

wants to merge 3 commits into from

Conversation

deafloo
Copy link

@deafloo deafloo commented Feb 27, 2023

Description

Naturally supports 0.66" (aka 64x48) OLED displays. Previously, the displays had to be implemented by OLED_DISPLAY_CUSTOM option.
Since the position of pixels in the controller memory matrix varies based on manufacturer, the OLED_COLUMN_OFFSET now works with sh1106 and ssd1306 controllers.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Feb 27, 2023
@deafloo deafloo marked this pull request as ready for review February 27, 2023 14:40
@drashna
Copy link
Member

drashna commented Mar 10, 2023

I know that @sigprof has an older PR that supports a number of different screens:
#10379

Additionally, tzarc has a PR for adding oled support to quantum painter:
#19997

@drashna drashna closed this May 10, 2023
@drashna
Copy link
Member

drashna commented May 10, 2023

#20331 should supersede this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants