Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keymap.h #20004

Merged
merged 1 commit into from
Mar 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion quantum/action.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#include "host.h"
#include "keycode.h"
#include "keyboard.h"
#include "keymap.h"
#include "mousekey.h"
#include "programmable_button.h"
#include "command.h"
Expand All @@ -30,6 +29,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#include "action.h"
#include "wait.h"
#include "keycode_config.h"
#include "debug.h"

#ifdef BACKLIGHT_ENABLE
# include "backlight.h"
Expand Down
2 changes: 1 addition & 1 deletion quantum/action_layer.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
#include <stdint.h>

#include "keyboard.h"
#include "keymap.h"
#include "action.h"
#include "encoder.h"
#include "util.h"
#include "action_layer.h"

Expand Down
2 changes: 1 addition & 1 deletion quantum/keyboard.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#include "quantum.h"
#include "keyboard.h"
#include "matrix.h"
#include "keymap.h"
#include "keymap_introspection.h"
#include "magic.h"
#include "host.h"
#include "led.h"
Expand Down
22 changes: 1 addition & 21 deletions quantum/keymap.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,4 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#pragma once

#include <stdint.h>
#include <stdbool.h>
#include "platform_deps.h"
#include "action.h"
#include "keycode.h"
#include "report.h"
#include "host.h"
#include "debug.h"
#include "keycode_config.h"
#include "gpio.h" // for pin_t

#include "quantum_keycodes.h"

#include "keymap_common.h"

#ifdef ENCODER_MAP_ENABLE
// Ensure we have a forward declaration for the encoder map
# include "encoder.h"
#endif

#include "keymap_introspection.h"
#pragma message("'keymap.h' should no longer be included!")
zvecr marked this conversation as resolved.
Show resolved Hide resolved
3 changes: 2 additions & 1 deletion quantum/keymap_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#include "keymap.h"
#include "keymap_common.h"
#include "keymap_introspection.h"
#include "report.h"
#include "keycode.h"
#include "action_layer.h"
Expand Down
1 change: 1 addition & 0 deletions quantum/keymap_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#pragma once

#include <stdint.h>
#include "keyboard.h"

// translates key to keycode
uint16_t keymap_key_to_keycode(uint8_t layer, keypos_t key);
1 change: 1 addition & 0 deletions quantum/process_keycode/process_combo.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#include "keymap_common.h"
#include "print.h"
#include "process_combo.h"
#include "action_tapping.h"
Expand Down
7 changes: 6 additions & 1 deletion quantum/quantum.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include "platform_deps.h"
#include "wait.h"
#include "matrix.h"
#include "keymap.h"
#include "keyboard.h"

#ifdef BACKLIGHT_ENABLE
# include "backlight.h"
Expand All @@ -36,6 +36,9 @@
# include "rgb_matrix.h"
#endif

#include "keymap_common.h"
#include "quantum_keycodes.h"
#include "keycode_config.h"
#include "action_layer.h"
#include "eeconfig.h"
#include "bootloader.h"
Expand All @@ -44,10 +47,12 @@
#include "sync_timer.h"
#include "gpio.h"
#include "atomic_util.h"
#include "host.h"
#include "led.h"
#include "action_util.h"
#include "action_tapping.h"
#include "print.h"
#include "debug.h"
#include "suspend.h"
#include <stddef.h>
#include <stdlib.h>
Expand Down