Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quantum Painter QoL enhancements -- auto-poweroff, auto-flush, buffer sizing #20013

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Quantum Painter QoL enhancements -- auto-poweroff, auto-flush, buffer sizing #20013

merged 1 commit into from
Mar 20, 2023

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Mar 4, 2023

Description

As per the title.
Split keyboard display auto-turnoff is not currently supported as it relies on the last input activity timestamps to be sync'ed. Separate PR will follow.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team March 4, 2023 12:04
@elpekenin elpekenin mentioned this pull request Mar 6, 2023
Draft
14 tasks
@drashna drashna requested a review from a team March 10, 2023 08:51
daskygit
daskygit reviewed Mar 19, 2023
View reviewed changes
Copy link
Member

@daskygit daskygit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well with my basic QP + LVGL setup. A bit of a nitpick but shouldn't the timer to sync_timer changes ideally be a different PR?

@tzarc
Copy link
Member Author

tzarc commented Mar 19, 2023

Working well with my basic QP + LVGL setup. A bit of a nitpick but shouldn't the timer to sync_timer changes ideally be a different PR?

Correct, seems I pushed a commit from the split branch. Will rollback.

@tzarc tzarc merged commit cd94ba0 into qmk:develop Mar 20, 2023
@tzarc tzarc deleted the qp-display-timeout branch March 20, 2023 03:13
nicsuzor pushed a commit to nicsuzor/qmk_firmware that referenced this pull request Mar 28, 2023
@tzarc @nicsuzor
Quantum Painter QoL enhancements -- auto-poweroff, auto-flush, buffer…
97da773 
… sizing (qmk#20013)
@elpekenin elpekenin mentioned this pull request Apr 29, 2023
Merged
14 tasks
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@tzarc @coquizen
Quantum Painter QoL enhancements -- auto-poweroff, auto-flush, buffer…
83790b4 
… sizing (qmk#20013)
@elpekenin elpekenin mentioned this pull request Jul 2, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpekenin elpekenin elpekenin left review comments

@drashna drashna drashna approved these changes

@daskygit daskygit daskygit approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tzarc @drashna @daskygit @elpekenin