Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rgblight layers when animations aren't enabled #20097

Merged
merged 1 commit into from
Mar 26, 2023

Commits on Mar 12, 2023

  1. Fix rgblight layers when animations aren't enabled

    PR qmk#18338 introduced a change that deferred rgblight_set after a call to
    rgblight_set_layer_state to the next invocation of rgblight_task.
    
    However, rgblight_task is a no-op unless RGBLIGHT_USE_TIMER is set,
    which only happens automatically if an RGB animation is enabled, or if
    RGBLIGHT_LAYER_BLINK is enabled.
    
    If neither of these are enabled, rgblight_set is never called
    automatically after rgblight_set_layer_state, so the LED state is never
    actually set.
    
    This commit fixes this issue by ensuring that RGBLIGHT_USER_TIMER is set
    if rgblight layers are enabled.
    elipsitz committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    ae87707 View commit details
    Browse the repository at this point in the history