Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ISO version of Durgod Hades #20110

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Add support for ISO version of Durgod Hades #20110

merged 2 commits into from
Apr 12, 2023

Conversation

ebastler
Copy link
Contributor

@ebastler ebastler commented Mar 13, 2023 •
edited
Loading

This PR expands QMK support for the Durgod Hades board (based on the ANSI firmware provided by J-Sully and dkjer) to the ISO version of this board.

Description

The existing ANSI version folder has been renamed, an ISO version added. Rules.mk paths have been adapted to ensure existing commands to build Durgod Hades will still build the ANSI version.

This firmware has been tested by a user on the QMK Discord and they confirmed both switches and LED positions to be working as intended.

I paid attention not to change anything else about the code, as it is shared between various Durgod PCBs and I lack hardware access to test anything but the ISO version of Hades which has been added with this PR.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 13, 2023
@ebastler
Copy link
Contributor Author

@dkjer @J-Sully since you provided the ANSI firmware, and adding the ISO version required me to make some changes to file paths of the ANSI version, I'd like to ping you here and ask if my changes are okay for you as well.

dkjer
dkjer reviewed Mar 21, 2023
View reviewed changes
keyboards/durgod/hades/iso/rules.mk Outdated
@@ -0,0 +1 @@
DEFAULT_FOLDER=durgod/dgk6x/hades_iso
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend mirroring this in durgod/hades/ansi/rules.mk.

I have created a PR for this: ebastler#1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! My original idea was to preserve the ANSI the way it is without changes, but this is probably better - merged!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, out of curiosity - did you get any files from durgod, or did you actually manage to reverse engineer the whole PCB from scratch? The ISO version only needed few changes, so it was mostly trial and error for me (and I happened to find the right way at first attempt), but reversing a whole per-key RGB PCB sounds really tough.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files from durgod; the initial version for K320 was based off from kuenhlee. The Hades/Venus/Galaxy board is similar to the K320 board, but required tweaking timings and tracking down wiring.

@dkjer
Copy link

dkjer commented Mar 21, 2023

This looks good to me!

@drashna drashna requested a review from a team March 29, 2023 19:30
@tzarc tzarc changed the base branch from master to develop April 3, 2023 23:01
@tzarc
Copy link
Member

tzarc commented Apr 3, 2023

Retargeted to develop due to moves.
Please resolve the conflicts and update the keyboard aliases file so that old invocations against hades now point at hades_ansi.

@ebastler
Copy link
Contributor Author

ebastler commented Apr 4, 2023

Sorry for the ugly force-push, saw no other way to resolve conflicts than re-create my branch off develop and re-apply changes. Also moved to data driven, and used aliases instead of DEFAULT_FOLDER lines in rules.mk files.

@ebastler @fauxpark
remove ifdefs around led driver configs
1d47889 
Co-authored-by: Ryan <fauxpark@gmail.com>
@thrly
Copy link

thrly commented Apr 12, 2023

very much looking forward to this! thanks!

@drashna drashna merged commit c57902d into qmk:develop Apr 12, 2023
@ebastler ebastler deleted the durgod_hades_iso branch April 12, 2023 15:50
@ebastler ebastler mentioned this pull request Apr 12, 2023
Merged
7 tasks
freznel10 added a commit to freznel10/qmk_firmware that referenced this pull request Apr 15, 2023
@freznel10
Squashed commit of the following:
3e07eef 
commit cf5626e
Author: Drashna Jaelre <drashna@drashna.net>
Date:   Wed Apr 12 21:43:27 2023 -0700

    [Bug] Fix compilation issues with PS/2 driver on F4x1 controllers (qmk#20433)

commit 572f863
Merge: d11c379 6d965d4
Author: QMK Bot <hello@qmk.fm>
Date:   Thu Apr 13 04:04:42 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 6d965d4
Author: Albert Y <76888457+filterpaper@users.noreply.github.com>
Date:   Thu Apr 13 12:04:02 2023 +0800

    Add hardware information momokai keyboards (qmk#20434)

commit d11c379
Author: Drashna Jaelre <drashna@drashna.net>
Date:   Wed Apr 12 17:59:07 2023 -0700

    [Keyboard] Update ymdk/id75 config (qmk#20432)

commit a41f6a3
Merge: 4a58db9 ce41722
Author: Drashna Jael're <drashna@live.com>
Date:   Wed Apr 12 14:36:45 2023 -0700

    Merge remote-tracking branch 'origin/master' into develop

commit ce41722
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Wed Apr 12 14:29:29 2023 -0700

    4pplet/eagle_viper_rep/rev_a Layout Macro Conversion and Additions (qmk#20414)

    * info.json: apply friendly formatting

    * add matrix_diagram.md

    * move matrix data to info.json

    * add LAYOUT_60_ansi_split_bs_rshift

    * add LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_hhkb

commit 4a58db9
Merge: 614a682 0382a25
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 19:29:26 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 0382a25
Author: Paulo Pereira <paulomp90@gmail.com>
Date:   Wed Apr 12 20:28:26 2023 +0100

    [Keymap] Add paulomp90 lily58 keymap (qmk#20327)

    Co-authored-by: Drashna Jaelre <drashna@live.com>

commit 614a682
Merge: 134586d 83dcbef
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 17:32:34 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 83dcbef
Author: Tommy Oldfield <oldfieldtc@gmail.com>
Date:   Wed Apr 12 18:31:47 2023 +0100

    [Keymap] Add personal keymap for Lily58 (qmk#18735)

commit 134586d
Merge: c57902d 18335dd
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 17:28:51 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 18335dd
Author: Josh Hinnebusch <joshhinnebusch@gmail.com>
Date:   Wed Apr 12 13:27:37 2023 -0400

    [Keyboard] Fix h87 g2 VID conflict (qmk#20388)

commit c57902d
Author: Moritz Plattner <moritz.plattner@gmx.net>
Date:   Wed Apr 12 17:36:28 2023 +0200

    [Keyboard] Add support for ISO version of Durgod Hades (qmk#20110)

    Co-authored-by: Ryan <fauxpark@gmail.com>

commit 41add95
Merge: a9ec2b3 051485c
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 15:35:55 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 051485c
Author: Ryan <PHSC138@users.noreply.github.com>
Date:   Wed Apr 12 11:35:12 2023 -0400

    [Keymap] PHSC138 Keymap for Atom47 (qmk#18768)

    Co-authored-by: Ryan <fauxpark@gmail.com>
    Co-authored-by: Drashna Jaelre <drashna@live.com>

commit a9ec2b3
Merge: 9994e8c 5012dfd
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 15:34:30 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 5012dfd
Author: Jeff Epler <jepler@gmail.com>
Date:   Wed Apr 12 09:33:42 2023 -0600

    [Keyboard] add kb2040 flavor of gherkin (qmk#18360)

commit 9994e8c
Merge: 1502193 641698d
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 15:08:47 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 641698d
Author: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Date:   Wed Apr 12 11:07:47 2023 -0400

    [Keyboard] ymdk/id75 (qmk#19967)

    Co-authored-by: jack <0x6a73@protonmail.com>
    Co-authored-by: Drashna Jaelre <drashna@live.com>

commit 1502193
Author: Manuel Ullmann <labre@posteo.de>
Date:   Wed Apr 12 14:24:07 2023 +0000

    quantum/action_util.c: Use uint8_t for oneshot_layer_data (qmk#20423)

commit e77699a
Author: Giuseppe Rota <403432+grota@users.noreply.github.com>
Date:   Wed Apr 12 16:22:07 2023 +0200

    Fix preprocessor condition for SPLIT_HAPTIC_ENABLE (qmk#20411)

commit e699724
Merge: 5bd68e3 75edefe
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 10:11:37 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 75edefe
Author: Mike Killewald <mkillewald@yahoo.com>
Date:   Wed Apr 12 06:10:50 2023 -0400

    fixing bug that caused KC_DEL and KC_MUTE (encoder press) to be swapped (qmk#20420)

commit 5bd68e3
Author: Ryan <fauxpark@gmail.com>
Date:   Wed Apr 12 13:42:51 2023 +1000

    Move single `LAYOUT`s to data driven (qmk#20365)

commit 941e159
Merge: fbf6727 7e6eba6
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue Apr 11 13:42:35 2023 -0700

    Merge remote-tracking branch 'origin/master' into develop

commit 7e6eba6
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue Apr 11 13:26:41 2023 -0700

    4pplet/bootleg/rev_a Layout Macro Conversion and Addition (qmk#20400)

    * info.json: apply friendly formatting

    * move matrix data to info.json

    * add LAYOUT_60_ansi_split_bs_rshift

commit fbf6727
Merge: b8d7f28 26b35a5
Author: QMK Bot <hello@qmk.fm>
Date:   Tue Apr 11 18:33:13 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 26b35a5
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue Apr 11 11:31:56 2023 -0700

    4pplet/aekiso60 Layout Macro Conversion and Additions (qmk#20399)

    * add matrix_diagram.md

    Adds `matrix_diagram.md` to the `4pplet/aekiso60` directory, and removes the diagrams from the keyboard revision header files.

    * info.json: apply friendly formatting

    * move matrix data to info.json

    * create keyboard-level info.json

    * add LAYOUT_60_iso_tsangan

    * enable Community Layout support

commit b8d7f28
Merge: ae1e6b7 38700f7
Author: QMK Bot <hello@qmk.fm>
Date:   Tue Apr 11 01:44:24 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 38700f7
Author: Joel Challis <git@zvecr.com>
Date:   Tue Apr 11 02:43:45 2023 +0100

    Reject info.json at keymap level (qmk#20408)

commit ae1e6b7
Merge: 6f77559 ed72c42
Author: QMK Bot <hello@qmk.fm>
Date:   Mon Apr 10 22:50:31 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit ed72c42
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 10 23:49:53 2023 +0100

    Bump anothrNick/github-tag-action from 1.61.0 to 1.62.0 (qmk#20407)

    Bumps [anothrNick/github-tag-action](https://github.com/anothrNick/github-tag-action) from 1.61.0 to 1.62.0.
    - [Release notes](https://github.com/anothrNick/github-tag-action/releases)
    - [Commits](anothrNick/github-tag-action@1.61.0...1.62.0)

    ---
    updated-dependencies:
    - dependency-name: anothrNick/github-tag-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 6f77559
Merge: d3b8179 bc6db28
Author: QMK Bot <hello@qmk.fm>
Date:   Mon Apr 10 19:33:02 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit bc6db28
Author: Vertex-kb <102476474+Vertex-kb@users.noreply.github.com>
Date:   Tue Apr 11 03:32:16 2023 +0800

    [Keyboard] Update angle65 VID/PID (qmk#20401)

commit d3b8179
Author: Ricardo Hermida Ruiz <rhruiz@gmail.com>
Date:   Mon Apr 10 09:45:25 2023 -0300

    Prevent Tri-Layer keys from stopping caps words (qmk#20398)
freznel10 added a commit to freznel10/qmk_firmware that referenced this pull request Apr 15, 2023
@freznel10
nesgit
c5fb30a 
Squashed commit of the following:

commit cf5626e
Author: Drashna Jaelre <drashna@drashna.net>
Date:   Wed Apr 12 21:43:27 2023 -0700

    [Bug] Fix compilation issues with PS/2 driver on F4x1 controllers (qmk#20433)

commit 572f863
Merge: d11c379 6d965d4
Author: QMK Bot <hello@qmk.fm>
Date:   Thu Apr 13 04:04:42 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 6d965d4
Author: Albert Y <76888457+filterpaper@users.noreply.github.com>
Date:   Thu Apr 13 12:04:02 2023 +0800

    Add hardware information momokai keyboards (qmk#20434)

commit d11c379
Author: Drashna Jaelre <drashna@drashna.net>
Date:   Wed Apr 12 17:59:07 2023 -0700

    [Keyboard] Update ymdk/id75 config (qmk#20432)

commit a41f6a3
Merge: 4a58db9 ce41722
Author: Drashna Jael're <drashna@live.com>
Date:   Wed Apr 12 14:36:45 2023 -0700

    Merge remote-tracking branch 'origin/master' into develop

commit ce41722
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Wed Apr 12 14:29:29 2023 -0700

    4pplet/eagle_viper_rep/rev_a Layout Macro Conversion and Additions (qmk#20414)

    * info.json: apply friendly formatting

    * add matrix_diagram.md

    * move matrix data to info.json

    * add LAYOUT_60_ansi_split_bs_rshift

    * add LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_hhkb

commit 4a58db9
Merge: 614a682 0382a25
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 19:29:26 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 0382a25
Author: Paulo Pereira <paulomp90@gmail.com>
Date:   Wed Apr 12 20:28:26 2023 +0100

    [Keymap] Add paulomp90 lily58 keymap (qmk#20327)

    Co-authored-by: Drashna Jaelre <drashna@live.com>

commit 614a682
Merge: 134586d 83dcbef
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 17:32:34 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 83dcbef
Author: Tommy Oldfield <oldfieldtc@gmail.com>
Date:   Wed Apr 12 18:31:47 2023 +0100

    [Keymap] Add personal keymap for Lily58 (qmk#18735)

commit 134586d
Merge: c57902d 18335dd
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 17:28:51 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 18335dd
Author: Josh Hinnebusch <joshhinnebusch@gmail.com>
Date:   Wed Apr 12 13:27:37 2023 -0400

    [Keyboard] Fix h87 g2 VID conflict (qmk#20388)

commit c57902d
Author: Moritz Plattner <moritz.plattner@gmx.net>
Date:   Wed Apr 12 17:36:28 2023 +0200

    [Keyboard] Add support for ISO version of Durgod Hades (qmk#20110)

    Co-authored-by: Ryan <fauxpark@gmail.com>

commit 41add95
Merge: a9ec2b3 051485c
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 15:35:55 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 051485c
Author: Ryan <PHSC138@users.noreply.github.com>
Date:   Wed Apr 12 11:35:12 2023 -0400

    [Keymap] PHSC138 Keymap for Atom47 (qmk#18768)

    Co-authored-by: Ryan <fauxpark@gmail.com>
    Co-authored-by: Drashna Jaelre <drashna@live.com>

commit a9ec2b3
Merge: 9994e8c 5012dfd
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 15:34:30 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 5012dfd
Author: Jeff Epler <jepler@gmail.com>
Date:   Wed Apr 12 09:33:42 2023 -0600

    [Keyboard] add kb2040 flavor of gherkin (qmk#18360)

commit 9994e8c
Merge: 1502193 641698d
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 15:08:47 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 641698d
Author: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Date:   Wed Apr 12 11:07:47 2023 -0400

    [Keyboard] ymdk/id75 (qmk#19967)

    Co-authored-by: jack <0x6a73@protonmail.com>
    Co-authored-by: Drashna Jaelre <drashna@live.com>

commit 1502193
Author: Manuel Ullmann <labre@posteo.de>
Date:   Wed Apr 12 14:24:07 2023 +0000

    quantum/action_util.c: Use uint8_t for oneshot_layer_data (qmk#20423)

commit e77699a
Author: Giuseppe Rota <403432+grota@users.noreply.github.com>
Date:   Wed Apr 12 16:22:07 2023 +0200

    Fix preprocessor condition for SPLIT_HAPTIC_ENABLE (qmk#20411)

commit e699724
Merge: 5bd68e3 75edefe
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 10:11:37 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 75edefe
Author: Mike Killewald <mkillewald@yahoo.com>
Date:   Wed Apr 12 06:10:50 2023 -0400

    fixing bug that caused KC_DEL and KC_MUTE (encoder press) to be swapped (qmk#20420)

commit 5bd68e3
Author: Ryan <fauxpark@gmail.com>
Date:   Wed Apr 12 13:42:51 2023 +1000

    Move single `LAYOUT`s to data driven (qmk#20365)

commit 941e159
Merge: fbf6727 7e6eba6
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue Apr 11 13:42:35 2023 -0700

    Merge remote-tracking branch 'origin/master' into develop

commit 7e6eba6
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue Apr 11 13:26:41 2023 -0700

    4pplet/bootleg/rev_a Layout Macro Conversion and Addition (qmk#20400)

    * info.json: apply friendly formatting

    * move matrix data to info.json

    * add LAYOUT_60_ansi_split_bs_rshift

commit fbf6727
Merge: b8d7f28 26b35a5
Author: QMK Bot <hello@qmk.fm>
Date:   Tue Apr 11 18:33:13 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 26b35a5
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue Apr 11 11:31:56 2023 -0700

    4pplet/aekiso60 Layout Macro Conversion and Additions (qmk#20399)

    * add matrix_diagram.md

    Adds `matrix_diagram.md` to the `4pplet/aekiso60` directory, and removes the diagrams from the keyboard revision header files.

    * info.json: apply friendly formatting

    * move matrix data to info.json

    * create keyboard-level info.json

    * add LAYOUT_60_iso_tsangan

    * enable Community Layout support

commit b8d7f28
Merge: ae1e6b7 38700f7
Author: QMK Bot <hello@qmk.fm>
Date:   Tue Apr 11 01:44:24 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 38700f7
Author: Joel Challis <git@zvecr.com>
Date:   Tue Apr 11 02:43:45 2023 +0100

    Reject info.json at keymap level (qmk#20408)

commit ae1e6b7
Merge: 6f77559 ed72c42
Author: QMK Bot <hello@qmk.fm>
Date:   Mon Apr 10 22:50:31 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit ed72c42
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 10 23:49:53 2023 +0100

    Bump anothrNick/github-tag-action from 1.61.0 to 1.62.0 (qmk#20407)

    Bumps [anothrNick/github-tag-action](https://github.com/anothrNick/github-tag-action) from 1.61.0 to 1.62.0.
    - [Release notes](https://github.com/anothrNick/github-tag-action/releases)
    - [Commits](anothrNick/github-tag-action@1.61.0...1.62.0)

    ---
    updated-dependencies:
    - dependency-name: anothrNick/github-tag-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 6f77559
Merge: d3b8179 bc6db28
Author: QMK Bot <hello@qmk.fm>
Date:   Mon Apr 10 19:33:02 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit bc6db28
Author: Vertex-kb <102476474+Vertex-kb@users.noreply.github.com>
Date:   Tue Apr 11 03:32:16 2023 +0800

    [Keyboard] Update angle65 VID/PID (qmk#20401)

commit d3b8179
Author: Ricardo Hermida Ruiz <rhruiz@gmail.com>
Date:   Mon Apr 10 09:45:25 2023 -0300

    Prevent Tri-Layer keys from stopping caps words (qmk#20398)
freznel10 added a commit to freznel10/qmk_firmware that referenced this pull request Apr 15, 2023
@freznel10
new
c781804 
Squashed commit of the following:

commit a67ace0
Merge: c5fb30a c9f6191
Author: freznel10 <freznel@gmail.com>
Date:   Sat Apr 15 23:36:29 2023 +0800

    Merge remote-tracking branch 'upstream/develop' into refactor_mouse

commit c9f6191
Author: Nick Brassel <nick@tzarc.org>
Date:   Sun Apr 16 01:18:44 2023 +1000

    Encodermap direction define. (qmk#20454)

commit 0ddb7d7
Author: Ryan <fauxpark@gmail.com>
Date:   Sat Apr 15 21:09:08 2023 +1000

    Move single `60_ansi`, `60_hhkb` and `60_iso` layouts to data driven (qmk#20438)

commit 172a406
Author: Ryan <fauxpark@gmail.com>
Date:   Sat Apr 15 21:08:15 2023 +1000

    Move single `LAYOUT_all`s to data driven (qmk#20430)

commit a84528f
Author: Ryan <fauxpark@gmail.com>
Date:   Sat Apr 15 21:07:32 2023 +1000

    Move remaining `LAYOUT`s to data driven (qmk#20422)

commit 54634e9
Author: Ryan <fauxpark@gmail.com>
Date:   Fri Apr 14 19:42:50 2023 +1000

    Fix some missing QMK_KEYBOARD_H includes in user keymaps (qmk#20417)

commit cf5626e
Author: Drashna Jaelre <drashna@drashna.net>
Date:   Wed Apr 12 21:43:27 2023 -0700

    [Bug] Fix compilation issues with PS/2 driver on F4x1 controllers (qmk#20433)

commit 572f863
Merge: d11c379 6d965d4
Author: QMK Bot <hello@qmk.fm>
Date:   Thu Apr 13 04:04:42 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 6d965d4
Author: Albert Y <76888457+filterpaper@users.noreply.github.com>
Date:   Thu Apr 13 12:04:02 2023 +0800

    Add hardware information momokai keyboards (qmk#20434)

commit d11c379
Author: Drashna Jaelre <drashna@drashna.net>
Date:   Wed Apr 12 17:59:07 2023 -0700

    [Keyboard] Update ymdk/id75 config (qmk#20432)

commit a41f6a3
Merge: 4a58db9 ce41722
Author: Drashna Jael're <drashna@live.com>
Date:   Wed Apr 12 14:36:45 2023 -0700

    Merge remote-tracking branch 'origin/master' into develop

commit ce41722
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Wed Apr 12 14:29:29 2023 -0700

    4pplet/eagle_viper_rep/rev_a Layout Macro Conversion and Additions (qmk#20414)

    * info.json: apply friendly formatting

    * add matrix_diagram.md

    * move matrix data to info.json

    * add LAYOUT_60_ansi_split_bs_rshift

    * add LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_hhkb

commit 4a58db9
Merge: 614a682 0382a25
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 19:29:26 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 0382a25
Author: Paulo Pereira <paulomp90@gmail.com>
Date:   Wed Apr 12 20:28:26 2023 +0100

    [Keymap] Add paulomp90 lily58 keymap (qmk#20327)

    Co-authored-by: Drashna Jaelre <drashna@live.com>

commit 614a682
Merge: 134586d 83dcbef
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 17:32:34 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 83dcbef
Author: Tommy Oldfield <oldfieldtc@gmail.com>
Date:   Wed Apr 12 18:31:47 2023 +0100

    [Keymap] Add personal keymap for Lily58 (qmk#18735)

commit 134586d
Merge: c57902d 18335dd
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 17:28:51 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 18335dd
Author: Josh Hinnebusch <joshhinnebusch@gmail.com>
Date:   Wed Apr 12 13:27:37 2023 -0400

    [Keyboard] Fix h87 g2 VID conflict (qmk#20388)

commit c57902d
Author: Moritz Plattner <moritz.plattner@gmx.net>
Date:   Wed Apr 12 17:36:28 2023 +0200

    [Keyboard] Add support for ISO version of Durgod Hades (qmk#20110)

    Co-authored-by: Ryan <fauxpark@gmail.com>

commit 41add95
Merge: a9ec2b3 051485c
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 15:35:55 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 051485c
Author: Ryan <PHSC138@users.noreply.github.com>
Date:   Wed Apr 12 11:35:12 2023 -0400

    [Keymap] PHSC138 Keymap for Atom47 (qmk#18768)

    Co-authored-by: Ryan <fauxpark@gmail.com>
    Co-authored-by: Drashna Jaelre <drashna@live.com>

commit a9ec2b3
Merge: 9994e8c 5012dfd
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 15:34:30 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 5012dfd
Author: Jeff Epler <jepler@gmail.com>
Date:   Wed Apr 12 09:33:42 2023 -0600

    [Keyboard] add kb2040 flavor of gherkin (qmk#18360)

commit 9994e8c
Merge: 1502193 641698d
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 15:08:47 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 641698d
Author: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Date:   Wed Apr 12 11:07:47 2023 -0400

    [Keyboard] ymdk/id75 (qmk#19967)

    Co-authored-by: jack <0x6a73@protonmail.com>
    Co-authored-by: Drashna Jaelre <drashna@live.com>

commit 1502193
Author: Manuel Ullmann <labre@posteo.de>
Date:   Wed Apr 12 14:24:07 2023 +0000

    quantum/action_util.c: Use uint8_t for oneshot_layer_data (qmk#20423)

commit e77699a
Author: Giuseppe Rota <403432+grota@users.noreply.github.com>
Date:   Wed Apr 12 16:22:07 2023 +0200

    Fix preprocessor condition for SPLIT_HAPTIC_ENABLE (qmk#20411)

commit e699724
Merge: 5bd68e3 75edefe
Author: QMK Bot <hello@qmk.fm>
Date:   Wed Apr 12 10:11:37 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 75edefe
Author: Mike Killewald <mkillewald@yahoo.com>
Date:   Wed Apr 12 06:10:50 2023 -0400

    fixing bug that caused KC_DEL and KC_MUTE (encoder press) to be swapped (qmk#20420)

commit 5bd68e3
Author: Ryan <fauxpark@gmail.com>
Date:   Wed Apr 12 13:42:51 2023 +1000

    Move single `LAYOUT`s to data driven (qmk#20365)

commit 941e159
Merge: fbf6727 7e6eba6
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue Apr 11 13:42:35 2023 -0700

    Merge remote-tracking branch 'origin/master' into develop

commit 7e6eba6
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue Apr 11 13:26:41 2023 -0700

    4pplet/bootleg/rev_a Layout Macro Conversion and Addition (qmk#20400)

    * info.json: apply friendly formatting

    * move matrix data to info.json

    * add LAYOUT_60_ansi_split_bs_rshift

commit fbf6727
Merge: b8d7f28 26b35a5
Author: QMK Bot <hello@qmk.fm>
Date:   Tue Apr 11 18:33:13 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 26b35a5
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue Apr 11 11:31:56 2023 -0700

    4pplet/aekiso60 Layout Macro Conversion and Additions (qmk#20399)

    * add matrix_diagram.md

    Adds `matrix_diagram.md` to the `4pplet/aekiso60` directory, and removes the diagrams from the keyboard revision header files.

    * info.json: apply friendly formatting

    * move matrix data to info.json

    * create keyboard-level info.json

    * add LAYOUT_60_iso_tsangan

    * enable Community Layout support

commit b8d7f28
Merge: ae1e6b7 38700f7
Author: QMK Bot <hello@qmk.fm>
Date:   Tue Apr 11 01:44:24 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 38700f7
Author: Joel Challis <git@zvecr.com>
Date:   Tue Apr 11 02:43:45 2023 +0100

    Reject info.json at keymap level (qmk#20408)

commit ae1e6b7
Merge: 6f77559 ed72c42
Author: QMK Bot <hello@qmk.fm>
Date:   Mon Apr 10 22:50:31 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit ed72c42
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 10 23:49:53 2023 +0100

    Bump anothrNick/github-tag-action from 1.61.0 to 1.62.0 (qmk#20407)

    Bumps [anothrNick/github-tag-action](https://github.com/anothrNick/github-tag-action) from 1.61.0 to 1.62.0.
    - [Release notes](https://github.com/anothrNick/github-tag-action/releases)
    - [Commits](anothrNick/github-tag-action@1.61.0...1.62.0)

    ---
    updated-dependencies:
    - dependency-name: anothrNick/github-tag-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 6f77559
Merge: d3b8179 bc6db28
Author: QMK Bot <hello@qmk.fm>
Date:   Mon Apr 10 19:33:02 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit bc6db28
Author: Vertex-kb <102476474+Vertex-kb@users.noreply.github.com>
Date:   Tue Apr 11 03:32:16 2023 +0800

    [Keyboard] Update angle65 VID/PID (qmk#20401)

commit d3b8179
Author: Ricardo Hermida Ruiz <rhruiz@gmail.com>
Date:   Mon Apr 10 09:45:25 2023 -0300

    Prevent Tri-Layer keys from stopping caps words (qmk#20398)
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@ebastler @fauxpark @coquizen
[Keyboard] Add support for ISO version of Durgod Hades (qmk#20110)
415ea39 
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkjer dkjer dkjer left review comments

@fauxpark fauxpark fauxpark requested changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ebastler @dkjer @tzarc @thrly @drashna @fauxpark