Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layouts containing keys with multiple matrix positions #20191

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Mar 20, 2023

Description

Should be everything that would be flagged by #20039.

Cross-checked with VIA JSON (assuming it is correct) or schematics (converter/a1200) where available. The rest are best guess based on the key names in the layout macro.

jian's symmetrical layouts also had to be removed and replaced with normal layouts. This comprised the majority of the validation errors since every key was duplicated and there are four revisions of the board.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 20, 2023 02:37
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Mar 20, 2023
@fauxpark
Copy link
Member Author

SHA mismatches:

04001799fdd1a52f9156dad5ec489d88034184b3  40percentclub_ut47_default.hex          |     b1bfd0455559aea8209652766bcffc72ff54a5bb  40percentclub_ut47_default.hex
ee02630af920947c85f206b7b79c224dc171be3f  converter_hp_46010a_default.hex         |     206d162283a8e5d7ebf6ec5f9842d4323ac19066  converter_hp_46010a_default.hex
179a62d63688a5c0c8ba552cb0f3b2a9fab58d75  handwired_wabi_default.hex              |     fd5343eebd9e4e6be4d1c68a70d2438a2fcd35f7  handwired_wabi_default.hex
bfc3538a96cf3944830007bc21ec6dea41a6dd7f  keyhive_ut472_default.hex               |     eb920cda2e315cadeb6dfbedbc9716c32670c9ef  keyhive_ut472_default.hex
255ffff4d617e306b354d94acf2665b10b087c25  maxr1998_phoebe_default.hex             |     328181d6d2c774f6ed538d0b23e28e1892e1d426  maxr1998_phoebe_default.hex
9711ad972105eee25726a7ebab2726ecc5564258  mt_mt40_default.hex                     |     fe9f731158736ec6e654a143ee4979b21cc3e0ec  mt_mt40_default.hex
bb79b378e2594cd42942f8c95887bc04a09446f4  sx60_default.hex                        |     3788c149a684020e8dd255af6b6440ea76a03a81  sx60_default.hex
0329778ae57b31f545619cf68a4a1e5270297ac6  xiudi_xd96_default.hex                  |     d5929eff9a77cba1465025226c6fdb2528cc92fa  xiudi_xd96_default.hex

Should be as expected.

@fauxpark fauxpark merged commit 06664e8 into qmk:develop Mar 29, 2023
@fauxpark fauxpark deleted the fix-layouts-multiple-matrix-pos branch March 29, 2023 04:48
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants