Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync activity timestamps between sides. #20192

Merged
merged 4 commits into from
Mar 21, 2023
Merged

Sync activity timestamps between sides. #20192

merged 4 commits into from
Mar 21, 2023

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Mar 20, 2023 •
edited
Loading

Description

Adds the ability to synchronise the activity timestamps for both matrix and encoder across split.
Enables the use of those timestamps with timeouts -- QP already leverages these.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team March 20, 2023 04:03
@github-actions github-actions bot added core documentation keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 20, 2023
@tzarc tzarc changed the title Swap activity timers to sync equivalent APIs. Sync activity timestamps between sides. Mar 20, 2023
@github-actions github-actions bot removed via Adds via keymap and/or updates keyboard for via support keymap labels Mar 20, 2023
KarlK90
KarlK90 requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some locking in the transaction handlers.

quantum/split_common/transactions.c Outdated Show resolved Hide resolved
@tzarc @KarlK90
Update quantum/split_common/transactions.c
d98e147 
Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
@KarlK90 KarlK90 merged commit a518e1e into qmk:develop Mar 21, 2023
nicsuzor pushed a commit to nicsuzor/qmk_firmware that referenced this pull request Mar 28, 2023
@tzarc @KarlK90 @nicsuzor
Sync activity timestamps between sides. (qmk#20192)
679b3af 
Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
@tzarc tzarc deleted the qp-sync-timers branch March 29, 2023 07:17
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@tzarc @KarlK90 @coquizen
Sync activity timestamps between sides. (qmk#20192)
8af8ddc 
Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
core documentation keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzarc @KarlK90