Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AKB Vero Layout Macro Additions #20491

Merged
merged 8 commits into from
Apr 22, 2023
Merged

AKB Vero Layout Macro Additions #20491

merged 8 commits into from
Apr 22, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • adds four layout macros with reference keymaps
  • touch-up for LAYOUT_all macro (missing matrix position)
  • adds matrix diagram

cc @arnstadm (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 18, 2023
@noroadsleft noroadsleft requested a review from a team April 18, 2023 07:08
@drashna drashna requested a review from a team April 22, 2023 08:20
@noroadsleft noroadsleft merged commit 2f74cc8 into qmk:develop Apr 22, 2023
@noroadsleft noroadsleft deleted the kb_layouts/akb_vero branch April 22, 2023 19:50
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
AKB Vero Layout Macro Additions (qmk#20491)
2e0f9dd 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_60_true_hhkb_split_space with reference keymap

* add LAYOUT_60_true_hhkb with reference keymap

* add LAYOUT_60_true_hhkb_iso_split_space with reference keymap

* add LAYOUT_60_true_hhkb_iso with reference keymap

* add matrix position [2, 12] to LAYOUT_all

* assign position [2, 12] to `KC_NUHS` in `default`/`via` keymaps
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
AKB Vero Layout Macro Additions (qmk#20491)
24a6da3 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_60_true_hhkb_split_space with reference keymap

* add LAYOUT_60_true_hhkb with reference keymap

* add LAYOUT_60_true_hhkb_iso_split_space with reference keymap

* add LAYOUT_60_true_hhkb_iso with reference keymap

* add matrix position [2, 12] to LAYOUT_all

* assign position [2, 12] to `KC_NUHS` in `default`/`via` keymaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @drashna