Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cable Car Designs Cypher rev6 Layout Additions and Touch-Up #20518

Merged
merged 10 commits into from
Apr 24, 2023
Merged

Cable Car Designs Cypher rev6 Layout Additions and Touch-Up #20518

merged 10 commits into from
Apr 24, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • refactor keymaps
  • adds two layout macros
  • update keyboard metadata
  • add layout/matrix diagram

cc @westfoxtrot (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
add matrix_diagram.md
c3eec40
@noroadsleft
refactor default keymap
b963764 
- use four-space indent
- grid-align keycodes
- use QMK-native keycode alias for `RGB_MODE_RGBTEST`
@noroadsleft
refactor default_iso keymap
3ebda02 
- use four-space indent
- grid-align keycodes
@noroadsleft
refactor via keymap
45ee24e 
- use four-space indent
- grid-align keycodes
- use QMK-native keycode alias for `KC_TRNS`
@noroadsleft
info.json: apply friendly formatting
a5e506b
@noroadsleft
add maintainer and url keys to info.json
20449b7
@noroadsleft
add LAYOUT_ansi with reference keymap
8c478a1
@noroadsleft
add LAYOUT_iso; refactor default_iso keymap
d310ef6
@noroadsleft
standardize default and via keymaps
87639e0 
- use `QK_GESC` at top left
- use `KC_DEL` for right half of Split Backspace
- use `KC_NUHS` for Non-US Hash position
- use `KC_NUBS` for Non-Us Backslash position
- use `KC_RGUI` for middle right mod
@noroadsleft
add RGB Underglow keycodes to all keymap Function layers
d6aa2d6
@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 20, 2023
@noroadsleft noroadsleft requested a review from a team April 20, 2023 16:08
@noroadsleft noroadsleft merged commit a959847 into qmk:develop Apr 24, 2023
@noroadsleft noroadsleft deleted the kb_layouts/cablecardesigns_cypher_rev6 branch April 24, 2023 00:18
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
Cable Car Designs Cypher rev6 Layout Additions and Touch-Up (qmk#20518)
cde6148 
* add matrix_diagram.md

* refactor default keymap

- use four-space indent
- grid-align keycodes
- use QMK-native keycode alias for `RGB_MODE_RGBTEST`

* refactor default_iso keymap

- use four-space indent
- grid-align keycodes

* refactor via keymap

- use four-space indent
- grid-align keycodes
- use QMK-native keycode alias for `KC_TRNS`

* info.json: apply friendly formatting

* add maintainer and url keys to info.json

* add LAYOUT_ansi with reference keymap

* add LAYOUT_iso; refactor default_iso keymap

* standardize default and via keymaps

- use `QK_GESC` at top left
- use `KC_DEL` for right half of Split Backspace
- use `KC_NUHS` for Non-US Hash position
- use `KC_NUBS` for Non-Us Backslash position
- use `KC_RGUI` for middle right mod

* add RGB Underglow keycodes to all keymap Function layers
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
Cable Car Designs Cypher rev6 Layout Additions and Touch-Up (qmk#20518)
41cf7b7 
* add matrix_diagram.md

* refactor default keymap

- use four-space indent
- grid-align keycodes
- use QMK-native keycode alias for `RGB_MODE_RGBTEST`

* refactor default_iso keymap

- use four-space indent
- grid-align keycodes

* refactor via keymap

- use four-space indent
- grid-align keycodes
- use QMK-native keycode alias for `KC_TRNS`

* info.json: apply friendly formatting

* add maintainer and url keys to info.json

* add LAYOUT_ansi with reference keymap

* add LAYOUT_iso; refactor default_iso keymap

* standardize default and via keymaps

- use `QK_GESC` at top left
- use `KC_DEL` for right half of Split Backspace
- use `KC_NUHS` for Non-US Hash position
- use `KC_NUBS` for Non-Us Backslash position
- use `KC_RGUI` for middle right mod

* add RGB Underglow keycodes to all keymap Function layers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @drashna