Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CannonKeys Ellipse Hotswap Layout Macro Addition & Touch-Up #20560

Merged
merged 7 commits into from
Apr 26, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • adds one new layout macro
  • enables Community Layout support
  • refactors the default and via keymaps
  • adds layout/matrix diagram

cc @awkannan (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

- use four-space indent
- grid-align keycodes
The default keymap didn't make sense to me - it included keycodes for features that aren't supported, and the arrow key alignment on the function layer was wonky.
@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 25, 2023
@noroadsleft noroadsleft requested a review from a team April 25, 2023 18:27
@drashna drashna requested a review from a team April 26, 2023 01:26
@noroadsleft noroadsleft merged commit 4e749f0 into qmk:develop Apr 26, 2023
@noroadsleft noroadsleft deleted the kb_layouts/cannonkeys_ellipse_hs branch April 26, 2023 10:04
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
* add matrix_diagram.md

* info.json: apply friendly formatting

* rename LAYOUT_all to LAYOUT_60_tsangan_hhkb

* add LAYOUT_60_ansi_tsangan_split_rshift

* refactor default and via keymaps

- use four-space indent
- grid-align keycodes

* copy via keymap to default

The default keymap didn't make sense to me - it included keycodes for features that aren't supported, and the arrow key alignment on the function layer was wonky.

* enable Community Layout support
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
* add matrix_diagram.md

* info.json: apply friendly formatting

* rename LAYOUT_all to LAYOUT_60_tsangan_hhkb

* add LAYOUT_60_ansi_tsangan_split_rshift

* refactor default and via keymaps

- use four-space indent
- grid-align keycodes

* copy via keymap to default

The default keymap didn't make sense to me - it included keycodes for features that aren't supported, and the arrow key alignment on the function layer was wonky.

* enable Community Layout support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants