Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charue Charon Layout Macro Additions #20585

Merged
merged 7 commits into from
Apr 27, 2023
Merged

Charue Charon Layout Macro Additions #20585

merged 7 commits into from
Apr 27, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • adds four new layout macros
  • adds layout/matrix diagram
  • correct maintainer field in info.json (reference GitHub username)

cc @PiKeeb (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team April 27, 2023 04:09
@noroadsleft noroadsleft merged commit ed91c84 into qmk:develop Apr 27, 2023
@noroadsleft noroadsleft deleted the kb_layouts/charue_charon branch April 27, 2023 20:57
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
Charue Charon Layout Macro Additions (qmk#20585)
5e57c67 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_ansi_blocker_tsangan_split_bs

* add LAYOUT_ansi_blocker_tsangan

* add LAYOUT_iso_blocker_tsangan_split_bs

* add LAYOUT_iso_blocker_tsangan

* info.json: correct maintainer field

Reference the maintainer's GitHub username.
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
Charue Charon Layout Macro Additions (qmk#20585)
040f09e 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_ansi_blocker_tsangan_split_bs

* add LAYOUT_ansi_blocker_tsangan

* add LAYOUT_iso_blocker_tsangan_split_bs

* add LAYOUT_iso_blocker_tsangan

* info.json: correct maintainer field

Reference the maintainer's GitHub username.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @fauxpark