Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add dnworks/SBL #20652

Merged
merged 18 commits into from
May 9, 2023
Merged

[Keyboard] Add dnworks/SBL #20652

merged 18 commits into from
May 9, 2023

Conversation

itsme-zeix
Copy link
Contributor

@itsme-zeix itsme-zeix commented May 1, 2023 •
edited
Loading

Added support for SBL PCB.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 1, 2023
lesshonor
lesshonor suggested changes May 1, 2023
View reviewed changes
keyboards/dnworks/sbl/readme.md Outdated Show resolved Hide resolved
keyboards/dnworks/sbl/info.json Show resolved Hide resolved
keyboards/dnworks/sbl/config.h Outdated Show resolved Hide resolved
keyboards/dnworks/sbl/info.json Show resolved Hide resolved
keyboards/dnworks/sbl/info.json Outdated Show resolved Hide resolved
keyboards/dnworks/sbl/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/dnworks/sbl/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/dnworks/sbl/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/dnworks/sbl/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/dnworks/sbl/keymaps/via/keymap.c Outdated Show resolved Hide resolved
itsme-zeix and others added 12 commits May 2, 2023 14:39
@itsme-zeix @lesshonor
Update keyboards/dnworks/sbl/info.json
c6f049f 
LED Indicator info shifted from config.h to info.json

Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@itsme-zeix @lesshonor
Update keyboards/dnworks/sbl/readme.md
f7454fa 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@itsme-zeix @lesshonor
Update keyboards/dnworks/sbl/config.h
c4caf41 
LED Indicator info shifted from config.h to info.json

Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@itsme-zeix @lesshonor
Update keyboards/dnworks/sbl/info.json
b6222de 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@itsme-zeix @lesshonor
Update keyboards/dnworks/sbl/keymaps/default/keymap.c
81d4179 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@itsme-zeix @lesshonor
Update keyboards/dnworks/sbl/keymaps/default/keymap.c
1360c64 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@itsme-zeix @lesshonor
Update keyboards/dnworks/sbl/keymaps/default/keymap.c
ccfc350 
Removed blank keymap layers

Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@itsme-zeix @lesshonor
Update keyboards/dnworks/sbl/keymaps/via/keymap.c
6a64ca8 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@itsme-zeix @lesshonor
Update keyboards/dnworks/sbl/keymaps/via/keymap.c
ce7f536 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@itsme-zeix @lesshonor
Update keyboards/dnworks/sbl/keymaps/via/keymap.c
f5250ee 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@itsme-zeix @lesshonor
Update keyboards/dnworks/sbl/keymaps/via/keymap.c
20179ed 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@itsme-zeix @drashna
Update keyboards/dnworks/sbl/readme.md
2429443 
Changed to a reduced resolution image

Co-authored-by: Drashna Jaelre <drashna@live.com>
waffle87
waffle87 reviewed May 2, 2023
View reviewed changes
keyboards/dnworks/sbl/info.json Outdated Show resolved Hide resolved
keyboards/dnworks/sbl/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/dnworks/sbl/rules.mk Outdated Show resolved Hide resolved
@drashna drashna merged commit 5c2e668 into qmk:master May 9, 2023
@itsme-zeix itsme-zeix mentioned this pull request May 10, 2023
Merged
7 tasks
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@itsme-zeix @lesshonor
@drashna @autoferrit
[Keyboard] Add dnworks/SBL (qmk#20652)
b3467c7 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesshonor lesshonor lesshonor requested changes

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itsme-zeix @drashna @waffle87 @lesshonor