Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glacier Handwired Layout Macro Addition and Touch-Up #20661

Merged
merged 4 commits into from
May 1, 2023
Merged

Glacier Handwired Layout Macro Addition and Touch-Up #20661

merged 4 commits into from
May 1, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • correct Configurator key sequence error (off-by-one error inherited from original C-based implementation)
  • add one new layout macro
  • add layout/matrix diagram

cc @swiftrax (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team May 1, 2023 19:49
@drashna drashna merged commit 3e4f641 into qmk:develop May 1, 2023
@noroadsleft noroadsleft deleted the kb_layouts/handwired_swiftrax_glacier branch May 2, 2023 03:10
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
Glacier Handwired Layout Macro Addition and Touch-Up (qmk#20661)
0bfdc49
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
Glacier Handwired Layout Macro Addition and Touch-Up (qmk#20661)
22f46bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @fauxpark