Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PS/2 mouse 9-bit output with MOUSE_EXTENDED_REPORT #20734

Merged
merged 2 commits into from
May 20, 2023

Conversation

dkao
Copy link
Contributor

@dkao dkao commented May 6, 2023

Description

Support the 8-bit + sign-bit output from PS/2 using MOUSE_EXTENDED_REPORT.
Also gives user code more range to scale mouse movement.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label May 6, 2023
@drashna
Copy link
Member

drashna commented May 6, 2023

Honestly, it may be better to move the ps2 stuff over to the pointing device code, in general. It would simplify/solve a lot of this, I think.

@dkao
Copy link
Contributor Author

dkao commented May 6, 2023

Right, I was wondering why PS/2 mouse is a special case.
Does QMK still support only one pointing device? There are use cases that have a PS/2 mouse and some other pointing device.

@drashna
Copy link
Member

drashna commented May 6, 2023

It's mostly that way because they were added at different points, and I didn't have a ps2 device to test with.

That said, yeah, it's mostly just a single device only, at this point, but dasky has been working on making adding multiple devices a lot more seamless:
#20374

@freznel10
Copy link

freznel10 commented May 8, 2023

It's mostly that way because they were added at different points, and I didn't have a ps2 device to test with.

That said, yeah, it's mostly just a single device only, at this point, but dasky has been working on making adding multiple devices a lot more seamless: #20374

been rocking #20374 and tried porting ps2 trackpoint to it but I've been getting weird results as I can't make RP2040 PS/2 PIO driver to play nice with it:( I will chuck this to my ignorance

@drashna drashna requested a review from a team May 9, 2023 06:30
@tzarc tzarc merged commit e278715 into qmk:develop May 20, 2023
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants