Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rart60 Layout Additions #20785

Merged
merged 11 commits into from
May 9, 2023
Merged

Rart60 Layout Additions #20785

merged 11 commits into from
May 9, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • add eight new layout macros
  • add layout/matrix diagram

cc @alabahuy (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team May 8, 2023 07:55
fauxpark
fauxpark requested changes May 8, 2023
View reviewed changes
keyboards/rart/rart60/info.json Outdated Show resolved Hide resolved
keyboards/rart/rart60/info.json Outdated Show resolved Hide resolved
keyboards/rart/rart60/info.json Outdated Show resolved Hide resolved
keyboards/rart/rart60/info.json Outdated Show resolved Hide resolved
keyboards/rart/rart60/info.json Outdated Show resolved Hide resolved
keyboards/rart/rart60/info.json Outdated Show resolved Hide resolved
keyboards/rart/rart60/info.json Outdated Show resolved Hide resolved
keyboards/rart/rart60/info.json Outdated Show resolved Hide resolved
@noroadsleft @fauxpark
Apply suggestions from code review
95237bd 
Co-authored-by: Ryan <fauxpark@gmail.com>
@noroadsleft noroadsleft merged commit 20a1bd4 into qmk:develop May 9, 2023
@noroadsleft noroadsleft deleted the kb_layouts/rart_rart60 branch May 9, 2023 04:59
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @fauxpark @coquizen
Rart60 Layout Additions (qmk#20785)
9d668ab 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_ansi_tsangan_split_bs_rshift

* add LAYOUT_ansi_tsangan

* add LAYOUT_ansi_wkl_split_bs_rshift

* add LAYOUT_ansi_wkl

* add LAYOUT_ansi_hhkb_split_bs_rshift

* add LAYOUT_ansi_hhkb

* add LAYOUT_ansi_cwkl_split_bs_rshift

* add LAYOUT_ansi_cwkl

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

---------

Co-authored-by: Ryan <fauxpark@gmail.com>
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @fauxpark @autoferrit
Rart60 Layout Additions (qmk#20785)
ff72666 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_ansi_tsangan_split_bs_rshift

* add LAYOUT_ansi_tsangan

* add LAYOUT_ansi_wkl_split_bs_rshift

* add LAYOUT_ansi_wkl

* add LAYOUT_ansi_hhkb_split_bs_rshift

* add LAYOUT_ansi_hhkb

* add LAYOUT_ansi_cwkl_split_bs_rshift

* add LAYOUT_ansi_cwkl

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

---------

Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @fauxpark