Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RART75 Layout Additions #20788

Merged
merged 10 commits into from
May 9, 2023
Merged

RART75 Layout Additions #20788

merged 10 commits into from
May 9, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • add six layout macros
  • rename LAYOUT_all to LAYOUT_ansi_split_space_split_bs
  • refactor keymaps
  • add layout/matrix diagram

cc @alabahuy (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 8, 2023
@noroadsleft noroadsleft requested a review from a team May 8, 2023 09:40
@noroadsleft noroadsleft merged commit 2482e35 into qmk:develop May 9, 2023
@noroadsleft noroadsleft deleted the kb_layouts/rart_rart75 branch May 9, 2023 07:30
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
RART75 Layout Additions (qmk#20788)
cb33553 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_ansi_split_bs

* refactor keymaps

- use four-space indent
- update grid alignment of keycodes

* rename LAYOUT_all to LAYOUT_ansi_split_space_split_bs

* add LAYOUT_ansi_split_space

* add LAYOUT_ansi_rwkl_split_bs

* add LAYOUT_ansi_rwkl

* add LAYOUT_ansi_wkl_split_bs

* add LAYOUT_ansi_wkl
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
RART75 Layout Additions (qmk#20788)
f9dace1 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_ansi_split_bs

* refactor keymaps

- use four-space indent
- update grid alignment of keycodes

* rename LAYOUT_all to LAYOUT_ansi_split_space_split_bs

* add LAYOUT_ansi_split_space

* add LAYOUT_ansi_rwkl_split_bs

* add LAYOUT_ansi_rwkl

* add LAYOUT_ansi_wkl_split_bs

* add LAYOUT_ansi_wkl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @fauxpark