Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LD7032 support to QP. #20828

Merged
merged 14 commits into from
Sep 18, 2024
Merged

Add LD7032 support to QP. #20828

merged 14 commits into from
Sep 18, 2024

Conversation

daskygit
Copy link
Member

@daskygit daskygit commented May 9, 2023

Description

Depends on #19997

I've tested I2C using a 96x24 display.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@daskygit daskygit marked this pull request as draft May 9, 2023 23:32
@daskygit
Copy link
Member Author

daskygit commented May 9, 2023

It's pretty much ready to go minus the poor i2c/spi comms handling. Opened so duplicate work doesn't get done (although unlikely).

@daskygit daskygit marked this pull request as ready for review October 22, 2023 10:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 7, 2023
@daskygit daskygit added awaiting review and removed stale Issues or pull requests that have become inactive without resolution. labels Dec 7, 2023
@daskygit
Copy link
Member Author

daskygit commented Dec 7, 2023

best I sort the documentation conflicts

@daskygit daskygit removed the on hold label May 6, 2024
@tzarc tzarc self-assigned this Aug 12, 2024
@tzarc tzarc self-requested a review September 9, 2024 22:41
tzarc
tzarc requested changes Sep 9, 2024
View reviewed changes
drivers/painter/ld7032/qp_ld7032.c Outdated Show resolved Hide resolved
@daskygit @tzarc
Update drivers/painter/ld7032/qp_ld7032.c
3bed91c 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@drashna drashna requested a review from a team September 10, 2024 03:17
sigprof
sigprof requested changes Sep 10, 2024
View reviewed changes
docs/quantum_painter.md Outdated Show resolved Hide resolved
docs/quantum_painter.md Outdated Show resolved Hide resolved
sigprof
sigprof requested changes Sep 10, 2024
View reviewed changes
drivers/painter/ld7032/qp_ld7032.c Outdated Show resolved Hide resolved
drivers/painter/ld7032/qp_ld7032.c Outdated Show resolved Hide resolved
daskygit and others added 2 commits September 10, 2024 12:13
@daskygit @sigprof
Apply suggestions from code review
8c5fd16 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@daskygit @sigprof
Apply suggestions from code review
d1e15d7 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@tzarc tzarc merged commit 49e339b into qmk:develop Sep 18, 2024
5 checks passed
@tzarc tzarc removed their assignment Sep 18, 2024
@daskygit
Copy link
Member Author

Ta

@daskygit daskygit deleted the pr/qp_ld7032 branch September 18, 2024 14:52
itsme-zeix pushed a commit to itsme-zeix/qmk_firmware that referenced this pull request Oct 2, 2024
@daskygit @tzarc
@sigprof @itsme-zeix
Add LD7032 support to QP. (qmk#20828)
fae1779 
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@daskygit @tzarc
@sigprof @ilham-agustiawan
Add LD7032 support to QP. (qmk#20828)
26d1377 
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@daskygit @tzarc
@sigprof @smallketchup82
Add LD7032 support to QP. (qmk#20828)
9fab519 
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@daskygit @tzarc
@sigprof @jlaptavi
Add LD7032 support to QP. (qmk#20828)
e06fdd6 
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@daskygit @tzarc
@sigprof @DmNosachev
Add LD7032 support to QP. (qmk#20828)
6c25079 
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@daskygit @tzarc
@sigprof @SyrupSplashin
Add LD7032 support to QP. (qmk#20828)
eb9441f 
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigprof sigprof sigprof requested changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
awaiting review core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daskygit @sigprof @drashna @tzarc