-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The slf-atreus layout for the Keyboardio Atreus #20903
Conversation
Co-authored-by: Drashna Jaelre <drashna@live.com>
register_mods(MOD_BIT(KC_LSFT)); // For a layer-tap key, use `layer_on(_MY_LAYER)` here | ||
register_code16(KC_9); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can do this, instead:
register_mods(MOD_BIT(KC_LSFT)); // For a layer-tap key, use `layer_on(_MY_LAYER)` here | |
register_code16(KC_9); | |
register_code16(LSFT(KC_9)); |
Hi @drashna. I have made the change that you requested in the line you pointed out, and in the other (5) places that I used the same code in keymap.c I removed some commented out stuff on home row mods that I experimented with a while ago. Lines 19-29. I also removed the combos. So have made changes to config.h and rules.mk. I don't know whether this falls within the scope of changes that should be made in a pull request; I suspect not. Should I cancel this pull request and start a new one? Or is that simply making more work for people like you who review them? Thanks for your patience, Duncan. |
Merge branch 'master' of https://github.com/qmk/qmk_firmware into slf-atreus
Hi @drashna. I have made some minor updates to the comments in config.h. That appears to have unblocked/triggered the CI build which had been stuck since my last commit a few days ago. Thanks, Duncan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keymap name should be your GitHub username, and may not contain -
characters.
Merge branch 'master' of https://github.com/PoweredByPorridge/qmk_firmware into slf-atreus
It looks like you have changes to the submodules here. These need to be reverted before the PR can be approved. Rebasing sometimes will fix this. Otherwise, you'd want to do something like this to fix them: git checkout @@your-branch@@
# for each of the problematic repo's:
cd lib/chibios
git checkout qmk-master |
3e8f1e9
to
d8eb45f
Compare
@drashna. My apologies, I didn't spot your comment, a combination of work and a non-functioning computer. I now appear to be back in the state I was a month ago, but am not entirely sure where I should go from here. Thanks, Duncan. |
I'm going to close this pull request and start again. I have made a mess and shall go back to the start. Thank you for your help. |
slf-atreus layout
The slf (Stiff Little Fingers) layout helps me type with my slightly creaky fingers. It duplicates Control and Alt keys on the left and right, uses autoshift, and tap dances to minimize movement around the keyboard.
Types of Changes
Issues Fixed or Closed by This PR
Checklist
This pull request is the replacement for #20883 which was closed as invalid.
Thanks, Duncan.