Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The slf-atreus layout for the Keyboardio Atreus #20903

Closed
wants to merge 14 commits into from

Conversation

PoweredByPorridge
Copy link
Contributor

slf-atreus layout

The slf (Stiff Little Fingers) layout helps me type with my slightly creaky fingers. It duplicates Control and Alt keys on the left and right, uses autoshift, and tap dances to minimize movement around the keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

This pull request is the replacement for #20883 which was closed as invalid.

Thanks, Duncan.

Co-authored-by: Drashna Jaelre <drashna@live.com>
Comment on lines 133 to 134
register_mods(MOD_BIT(KC_LSFT)); // For a layer-tap key, use `layer_on(_MY_LAYER)` here
register_code16(KC_9);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do this, instead:

Suggested change
register_mods(MOD_BIT(KC_LSFT)); // For a layer-tap key, use `layer_on(_MY_LAYER)` here
register_code16(KC_9);
register_code16(LSFT(KC_9));

@PoweredByPorridge
Copy link
Contributor Author

Hi @drashna. I have made the change that you requested in the line you pointed out, and in the other (5) places that I used the same code in keymap.c

I removed some commented out stuff on home row mods that I experimented with a while ago. Lines 19-29.

I also removed the combos. So have made changes to config.h and rules.mk.

I don't know whether this falls within the scope of changes that should be made in a pull request; I suspect not. Should I cancel this pull request and start a new one? Or is that simply making more work for people like you who review them?

Thanks for your patience,

Duncan.

@PoweredByPorridge
Copy link
Contributor Author

Hi @drashna. I have made some minor updates to the comments in config.h. That appears to have unblocked/triggered the CI build which had been stuck since my last commit a few days ago.

Thanks, Duncan.

@drashna drashna requested a review from a team May 29, 2023 04:37
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keymap name should be your GitHub username, and may not contain - characters.

keyboards/keyboardio/atreus/keymaps/slf-atreus/rules.mk Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Jun 11, 2023

It looks like you have changes to the submodules here. These need to be reverted before the PR can be approved.

Rebasing sometimes will fix this. Otherwise, you'd want to do something like this to fix them:

git checkout @@your-branch@@
# for each of the problematic repo's:
cd lib/chibios
git checkout qmk-master

@PoweredByPorridge
Copy link
Contributor Author

@drashna. My apologies, I didn't spot your comment, a combination of work and a non-functioning computer. I now appear to be back in the state I was a month ago, but am not entirely sure where I should go from here.

Thanks, Duncan.

@PoweredByPorridge
Copy link
Contributor Author

I'm going to close this pull request and start again. I have made a mess and shall go back to the start. Thank you for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants