Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acheron Elongate Delta: rename LAYOUT_all to LAYOUT #20956

Merged
merged 1 commit into from
May 15, 2023
Merged

Acheron Elongate Delta: rename LAYOUT_all to LAYOUT #20956

merged 1 commit into from
May 15, 2023

Conversation

noroadsleft
Copy link
Member

Description

[title]

Keyboard only supports one layout.

cc @Gondolindrim (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

⚠ acheron/elongate/delta: "LAYOUT_all" should be "LAYOUT" unless additional layouts are provided.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team May 15, 2023 07:47
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 15, 2023
@drashna drashna requested a review from a team May 15, 2023 09:05
@zvecr zvecr merged commit 347d1c7 into qmk:develop May 15, 2023
@noroadsleft noroadsleft deleted the kb_layouts/acheron_elongate_delta branch May 15, 2023 16:07
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
acheron/elongate/delta: rename LAYOUT_all to LAYOUT (qmk#20956)
b3a85b7
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
acheron/elongate/delta: rename LAYOUT_all to LAYOUT (qmk#20956)
30f383b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noroadsleft @drashna @fauxpark @zvecr