Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Fixup Crkbd default keymap #20962

Merged
merged 3 commits into from
May 20, 2023

Conversation

drashna
Copy link
Member

@drashna drashna commented May 15, 2023

Description

Moves oled code to crkbd.c and out of default keymaps, moves more to datadriven, etc.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team May 15, 2023 19:09
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 15, 2023
@drashna drashna requested a review from a team May 16, 2023 05:01
@tzarc tzarc merged commit b93f05d into qmk:develop May 20, 2023
@drashna drashna deleted the keyboard/crkbd_defaults branch May 21, 2023 01:01
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants