Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix issue with Repeat Key-Combo test #21005

Merged
merged 1 commit into from
May 20, 2023
Merged

[Bug] Fix issue with Repeat Key-Combo test #21005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/repeat_key/repeat_key_combo/test.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@
REPEAT_KEY_ENABLE = yes

COMBO_ENABLE = yes
INTROSPECTION_KEYMAP_C = test_combos.c
8 changes: 8 additions & 0 deletions tests/repeat_key/repeat_key_combo/test_combos.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// Copyright 2023 Stefan Kerkmann (@KarlK90)
// Copyright 2023 @filterpaper
// Copyright 2023 Nick Brassel (@tzarc)
// SPDX-License-Identifier: GPL-2.0-or-later
#include "quantum.h"

const uint16_t xy_combo[] PROGMEM = {KC_X, KC_Y, COMBO_END};
combo_t key_combos[] = {COMBO(xy_combo, KC_Q)};
7 changes: 0 additions & 7 deletions tests/repeat_key/repeat_key_combo/test_repeat_key_combo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,6 @@ using ::testing::InSequence;

namespace {

extern "C" {
// Define a combo: KC_X + KC_Y = KC_Q.
const uint16_t xy_combo[] PROGMEM = {KC_X, KC_Y, COMBO_END};
combo_t key_combos[] = {COMBO(xy_combo, KC_Q)};
uint16_t COMBO_LEN = sizeof(key_combos) / sizeof(*key_combos);
} // extern "C"

class RepeatKey : public TestFixture {};

// Tests repeating a combo, KC_X + KC_Y = KC_Q, by typing
Expand Down