Refactor kinetic mouse key feature #21164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filterpaper
force-pushed
the
mk-kinetic-maths
branch
from
3af0ed0
to
383e7a3
Compare
drashna
reviewed
Jun 8, 2023
filterpaper
force-pushed
the
mk-kinetic-maths
branch
from
383e7a3
to
de62cbd
Compare
filterpaper
force-pushed
the
mk-kinetic-maths
branch
from
de62cbd
to
eed07dc
Compare
Replace multiplication of fractional decimal numbers with division by integer to avoid floating point operations. This change will result with smaller compiled firmware size.
filterpaper
force-pushed
the
mk-kinetic-maths
branch
from
eed07dc
to
8db030d
Compare
drashna
approved these changes
Jun 11, 2023
filterpaper
changed the title
14 tasks
Remove duplicate if-else conditions, refactor ternary statement for consistency with the rest of the file. Revert kinetc wheel step size to 1.
filterpaper
force-pushed
the
mk-kinetic-maths
branch
from
37828d0
to
c736ad0
Compare
drashna
approved these changes
Jun 21, 2023
tzarc
approved these changes
Jul 7, 2023
jesperhellberg
pushed a commit
to jesperhellberg/qmk_firmware
that referenced
this pull request
Sep 9, 2023
thismarvin
pushed a commit
to thismarvin/qmk_firmware
that referenced
this pull request
Sep 27, 2023
akeep
pushed a commit
to akeep/qmk_firmware
that referenced
this pull request
Oct 2, 2023
csolje
pushed a commit
to csolje/qmk_firmware
that referenced
this pull request
Oct 21, 2023
autoferrit
pushed a commit
to SpaceRockMedia/bastardkb-qmk
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace multiplication of fractional decimal numbers with division by integer to avoid floating point operations. This change will reduce compiled firmware size.
Simplify duplicate
ifconditions and refactor ternary statements for consistency with the rest of the file.Revert mouse key wheel step size to
1because stuck mouse wheel issue was fixed in #17493.Types of Changes
Checklist