Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Chaz #21207

Closed
wants to merge 28 commits into from
Closed

Add support for Chaz #21207

wants to merge 28 commits into from

Conversation

jasonhazel
Copy link
Contributor

Description

Adding support for Chaz.

Had a previous PR for this board (#21091) but after seeing #21186 I closed it rework for RP2040 configurator support.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Jason Hazel and others added 21 commits May 30, 2023 22:11
adding chaz config
af4c103
rename layout
5d326e6
adding url to info.json
635dace
remove IGNORE_MOD_TAP_INTERRUPT
c9fbfdd
remove TAPPING_TERM_PER_KEY
be149b9
add development_board to info.json
f0c8663
update readme image url
016070f
@jasonhazel @zvecr
Update keyboards/hazel/chaz/info.json
1d281c8 
Co-authored-by: Joel Challis <git@zvecr.com>
@jasonhazel @zvecr
Update keyboards/hazel/chaz/info.json
fe9fbd7 
Co-authored-by: Joel Challis <git@zvecr.com>
@jasonhazel @zvecr
Update keyboards/hazel/chaz/info.json
5aeb0c9 
Co-authored-by: Joel Challis <git@zvecr.com>
@jasonhazel @zvecr
Update keyboards/hazel/chaz/rules.mk
253f9fc 
Co-authored-by: Joel Challis <git@zvecr.com>
remove DOUBLE_TAP_SHIFT_TURNS_ON_CAPS_WORD from default keymap
313c938
@jasonhazel
adding store link
5467b37
break out into two 'keyboards' for rp2040 configurator support
d47e39a
Merge branch 'hazel/chaz' of github.com:jasonhazel/qmk_firmware into …
76fe94e 
…hazel/chaz
rename rp2040 to rp2040ce
6f1e1ca
Merge branch 'master' into hazel/chaz
f86f3d0
will keymaps work like this?
e61aa9b
moving files around again
0a772e6
specify atmega32u4
9a91c37
Merge branch 'master' into hazel/chaz
b50f2af
@jasonhazel
Copy link
Contributor Author

I saw some comments come through relating to info.json information duplicated across files. I went to reply and they're missing now so I assume a single, all encompassing comment is coming?

There is a lot of overlap between the two version info.json. Is it safe to assume all of that overlap can be moved to the top level info.json?

@dunk2k
Copy link
Contributor

dunk2k commented Jun 10, 2023

@jasonhazel

There is a lot of overlap between the two version info.json. Is it safe to assume all of that overlap can be moved to the top level info.json?

you got it chief! There's argument for moving/merging the readme.md's to keyboard level, but I'll let the collaborators call that one 😉

@jasonhazel
Copy link
Contributor Author

@dunk2k right on. I applied your suggestions and will wait to see what the collaborators say about the readme. Thanks for your feedback!

waffle87
waffle87 requested changes Jun 10, 2023
View reviewed changes
keyboards/hazel/chaz/keymaps/default/keymap.json Outdated Show resolved Hide resolved
keyboards/hazel/chaz/keymaps/jasonhazel/config.h Outdated Show resolved Hide resolved
keyboards/hazel/chaz/keymaps/jasonhazel/keymap.json Outdated Show resolved Hide resolved
keyboards/hazel/chaz/promicro/readme.md Outdated Show resolved Hide resolved
jasonhazel and others added 2 commits June 10, 2023 16:17
@jasonhazel @waffle87
Apply suggestions from code review
3305074 
Co-authored-by: jack <0x6a73@protonmail.com>
consolidate readme
569ef6a
@waffle87 waffle87 requested a review from a team June 10, 2023 20:29
drashna
drashna reviewed Jun 12, 2023
View reviewed changes
keyboards/hazel/chaz/rp2040ce/info.json Outdated
@@ -0,0 +1,9 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's using the same pinout as the pro micro, correct?

@jasonhazel
Copy link
Contributor Author

@drashna I realized converters could be specified via rules.mk. I've rearranged things to a single top-level info.json with promicro pins specified and then a sub directory for rp2040ce with the converter defined in the rules.mk.

fauxpark
fauxpark requested changes Jun 13, 2023
View reviewed changes
keyboards/hazel/chaz/rp2040ce/rules.mk
@@ -0,0 +1 @@
CONVERT_TO=rp2040_ce
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converters at keyboard level won't work with Configurator.

@jasonhazel jasonhazel closed this Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@fauxpark fauxpark fauxpark requested changes

@waffle87 waffle87 waffle87 approved these changes

@dunk2k dunk2k dunk2k approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasonhazel @dunk2k @drashna @fauxpark @waffle87