-
-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimal hooks for SN32 flashing support #21228
Conversation
cli integration status:
QMK Toolbox: qmk/qmk_toolbox#413 |
|
PR is good to go. Review at your convenience |
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
with #21217 now merged, bumping this in hopes to make it in this merge cycle. |
parsed_version = _parse_gcc_version(version_number) | ||
if (parsed_version['major'], parsed_version['minor']) < (10, 3): | ||
cli.log.warning('{fg_yellow}We do not recommend arm-none-eabi-gcc older than 10.3.x. Upgrading to 10.3.x or higher is recommended.') | ||
return CheckStatus.WARNING | ||
|
||
return CheckStatus.OK # arm versions less than 10.3.x cause issues on sn32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reason for this is occasional and random hardfaults when built against those versions in arm m0. The toolchain version that first fixed it was arm-none-eabi-gcc (GNU Arm Embedded Toolchain 10-2020-q4-major)
. Bumping the version one up makes sure the right one is selected ( up until q2 it was buggy). No known issues exist with current latest version, tested extensively with every major release from 10.3 onwards.
while my original notes are lost on this, I believe this to be the bug
After internal discussion, this isn't in alignment with the strategic direction QMK has chosen to take. Thanks for the effort put in, but we've chosen not to include this PR with QMK. |
Bare essentials for
qmk flash
support in sn32 boards.Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist