Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal hooks for SN32 flashing support #21228

Closed
wants to merge 11 commits into from

Conversation

dexter93
Copy link
Contributor

@dexter93 dexter93 commented Jun 13, 2023

Bare essentials for qmk flash support in sn32 boards.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

lib/python/qmk/cli/doctor/check.py Outdated Show resolved Hide resolved
@dexter93
Copy link
Contributor Author

dexter93 commented Jun 14, 2023

@dexter93
Copy link
Contributor Author

dexter93 commented Jun 14, 2023

util/drivers.txt probably needs revisit. will update soon
done.

@dexter93
Copy link
Contributor Author

PR is good to go. Review at your convenience

@dexter93 dexter93 requested a review from sigprof June 15, 2023 17:10
@dexter93
Copy link
Contributor Author

dexter93 commented Jul 8, 2023

with #21217 now merged, bumping this in hopes to make it in this merge cycle.

Comment on lines +47 to +52
parsed_version = _parse_gcc_version(version_number)
if (parsed_version['major'], parsed_version['minor']) < (10, 3):
cli.log.warning('{fg_yellow}We do not recommend arm-none-eabi-gcc older than 10.3.x. Upgrading to 10.3.x or higher is recommended.')
return CheckStatus.WARNING

return CheckStatus.OK # arm versions less than 10.3.x cause issues on sn32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason for this is occasional and random hardfaults when built against those versions in arm m0. The toolchain version that first fixed it was arm-none-eabi-gcc (GNU Arm Embedded Toolchain 10-2020-q4-major). Bumping the version one up makes sure the right one is selected ( up until q2 it was buggy). No known issues exist with current latest version, tested extensively with every major release from 10.3 onwards.

while my original notes are lost on this, I believe this to be the bug

@tzarc
Copy link
Member

tzarc commented Aug 12, 2024

After internal discussion, this isn't in alignment with the strategic direction QMK has chosen to take. Thanks for the effort put in, but we've chosen not to include this PR with QMK.

@tzarc tzarc closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants