Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skyloong/Dt40 keyboard #21237

Merged
merged 15 commits into from
Jul 10, 2023
Merged

Add skyloong/Dt40 keyboard #21237

merged 15 commits into from
Jul 10, 2023

Conversation

JZ-Skyloong
Copy link
Contributor

Description

Add skyloong/Dt40 keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 14, 2023
lesshonor
lesshonor suggested changes Jun 14, 2023
View reviewed changes
keyboards/skyloong/dt40/info.json Outdated Show resolved Hide resolved
keyboards/skyloong/dt40/info.json Show resolved Hide resolved
JZ-Skyloong and others added 2 commits June 15, 2023 09:51
@JZ-Skyloong @lesshonor
Update keyboards/skyloong/dt40/info.json
8d1f33b 
OK, thank you for your suggestion.

Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@JZ-Skyloong
formatting for info.json
3f02406
@drashna drashna requested a review from a team June 15, 2023 03:34
@JZ-Skyloong @waffle87
Update keyboards/skyloong/dt40/keymaps/default/keymap.c
12349b5 
OK, thank you for your suggestion.

Co-authored-by: jack <0x6a73@protonmail.com>
fauxpark
fauxpark requested changes Jun 15, 2023
View reviewed changes
keyboards/skyloong/dt40/readme.md Outdated Show resolved Hide resolved
@JZ-Skyloong @fauxpark
Update keyboards/skyloong/dt40/readme.md
368e950 
OK, thank you for your suggestion.

Co-authored-by: Ryan <fauxpark@gmail.com>
JZ-Skyloong
JZ-Skyloong commented Jun 16, 2023
View reviewed changes
Copy link
Contributor Author

@JZ-Skyloong JZ-Skyloong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files were modified regarding to suggesting.

@JZ-Skyloong
Copy link
Contributor Author

QMK CI check shows a lack of two files crt1.td and chmtx.td, how can I correct it?

@JZ-Skyloong
Copy link
Contributor Author

PR has not been updated for a long time, what can I do next? @fauxpark @waffle87 @lesshonor @drashna

@waffle87 waffle87 merged commit 72cf966 into qmk:develop Jul 10, 2023
@JZ-Skyloong JZ-Skyloong deleted the dt40 branch July 10, 2023 02:57
@JZ-Skyloong JZ-Skyloong mentioned this pull request Aug 31, 2023
Merged
7 tasks
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@JZ-Skyloong @waffle87
@lesshonor @fauxpark @jesperhellberg
[Keyboard] Add skyloong/Dt40 (qmk#21237)
2d500bb 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@JZ-Skyloong @waffle87
@lesshonor @fauxpark @thismarvin
[Keyboard] Add skyloong/Dt40 (qmk#21237)
ab0654b 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@JZ-Skyloong @waffle87
@lesshonor @fauxpark @akeep
[Keyboard] Add skyloong/Dt40 (qmk#21237)
131bce2 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@JZ-Skyloong @waffle87
@lesshonor @fauxpark @csolje
[Keyboard] Add skyloong/Dt40 (qmk#21237)
0e5be70 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@JZ-Skyloong @waffle87
@lesshonor @fauxpark @autoferrit
[Keyboard] Add skyloong/Dt40 (qmk#21237)
86df02a 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 approved these changes

@lesshonor lesshonor lesshonor approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JZ-Skyloong @drashna @fauxpark @waffle87 @lesshonor