Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skyloong/Dt40 keyboard #21237

Merged
merged 15 commits into from
Jul 10, 2023
Merged

Add skyloong/Dt40 keyboard #21237

merged 15 commits into from
Jul 10, 2023

Conversation

JZ-Skyloong
Copy link
Contributor

Description

Add skyloong/Dt40 keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 14, 2023
keyboards/skyloong/dt40/info.json Outdated Show resolved Hide resolved
keyboards/skyloong/dt40/info.json Show resolved Hide resolved
JZ-Skyloong and others added 2 commits June 15, 2023 09:51
OK, thank you for your suggestion.

Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@drashna drashna requested a review from a team June 15, 2023 03:34
OK, thank you for your suggestion.

Co-authored-by: jack <0x6a73@protonmail.com>
keyboards/skyloong/dt40/readme.md Outdated Show resolved Hide resolved
OK, thank you for your suggestion.

Co-authored-by: Ryan <fauxpark@gmail.com>
Copy link
Contributor Author

@JZ-Skyloong JZ-Skyloong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files were modified regarding to suggesting.

@JZ-Skyloong
Copy link
Contributor Author

QMK CI check shows a lack of two files crt1.td and chmtx.td, how can I correct it?

@JZ-Skyloong
Copy link
Contributor Author

PR has not been updated for a long time, what can I do next? @fauxpark @waffle87 @lesshonor @drashna

@waffle87 waffle87 merged commit 72cf966 into qmk:develop Jul 10, 2023
@JZ-Skyloong JZ-Skyloong deleted the dt40 branch July 10, 2023 02:57
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants