Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TAPPING_TERM to data driven #21296

Merged
merged 5 commits into from
Jun 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion keyboards/25keys/zinc/rev1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#pragma once

#define QUICK_TAP_TERM 0
#define TAPPING_TERM 100

/* Select hand configuration */
#define MASTER_LEFT
Expand Down
3 changes: 3 additions & 0 deletions keyboards/25keys/zinc/rev1/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"split": {
"soft_serial_pin": "D2"
},
"tapping": {
"term": 100
},
"rgblight": {
"hue_steps": 10
},
Expand Down
1 change: 0 additions & 1 deletion keyboards/25keys/zinc/reva/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#pragma once

#define QUICK_TAP_TERM 0
#define TAPPING_TERM 100

/* Select hand configuration */
#define MASTER_LEFT
Expand Down
3 changes: 3 additions & 0 deletions keyboards/25keys/zinc/reva/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"split": {
"soft_serial_pin": "D2"
},
"tapping": {
"term": 100
},
"rgblight": {
"hue_steps": 10
},
Expand Down
3 changes: 3 additions & 0 deletions keyboards/adkb96/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
"split": {
"soft_serial_pin": "D0"
},
"tapping": {
"term": 100
},
"processor": "atmega32u4",
"bootloader": "caterina",
"layout_aliases": {
Expand Down
3 changes: 0 additions & 3 deletions keyboards/adkb96/rev1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#pragma once

/* define tapping term */
#define TAPPING_TERM 100

/* Mechanical locking support. Use KC_LCAP, KC_LNUM or KC_LSCR instead in keymap */
#define LOCKING_SUPPORT_ENABLE
/* Locking resynchronize hack */
Expand Down
3 changes: 0 additions & 3 deletions keyboards/bemeier/bmek/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,3 @@
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_MODE_STATIC_GRADIENT

//#define RETRO_TAPPING
#define TAPPING_TERM 175
3 changes: 3 additions & 0 deletions keyboards/bemeier/bmek/rev1/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
"brightness_steps": 8,
"led_count": 6
},
"tapping": {
"term": 175
},
"ws2812": {
"pin": "E6"
},
Expand Down
3 changes: 3 additions & 0 deletions keyboards/bemeier/bmek/rev2/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
"brightness_steps": 8,
"led_count": 6
},
"tapping": {
"term": 175
},
"ws2812": {
"pin": "E6"
},
Expand Down
3 changes: 3 additions & 0 deletions keyboards/bemeier/bmek/rev3/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
"brightness_steps": 8,
"led_count": 6
},
"tapping": {
"term": 175
},
"ws2812": {
"pin": "E6"
},
Expand Down
3 changes: 3 additions & 0 deletions keyboards/clickety_split/leeloo/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@
}
}
},
"tapping": {
"term": 100
},
"processor": "atmega32u4",
"bootloader": "caterina",
"layouts": {
Expand Down
37 changes: 0 additions & 37 deletions keyboards/clickety_split/leeloo/rev1/config.h

This file was deleted.

4 changes: 0 additions & 4 deletions keyboards/fc660c/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROWS 5
#define MATRIX_COLS 16

//#define DIODE_DIRECTION

#define TAPPING_TERM 175

/*
* Feature disable options
* These options are also useful to firmware size reduction.
Expand Down
3 changes: 3 additions & 0 deletions keyboards/fc660c/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"pid": "0x660C",
"device_version": "1.0.0"
},
"tapping": {
"term": 175
},
"indicators": {
"caps_lock": "B6",
"on_state": 0
Expand Down
3 changes: 0 additions & 3 deletions keyboards/h0oni/deskpad/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,3 @@
#define LOCKING_SUPPORT_ENABLE
/* Locking resynchronize hack */
#define LOCKING_RESYNC_ENABLE

/* Defining tapping term */
#define TAPPING_TERM 250
3 changes: 3 additions & 0 deletions keyboards/h0oni/deskpad/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"pid": "0x4450",
"device_version": "0.0.1"
},
"tapping": {
"term": 250
},
"matrix_pins": {
"cols": ["D0", "D4", "D1"],
"rows": ["D7", "C6"]
Expand Down
3 changes: 0 additions & 3 deletions keyboards/halokeys/elemental75/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@

//#define RGBLIGHT_DISABLE_KEYCODES

// Tap dance term declaration
#define TAPPING_TERM 300

/* Mechanical locking support. Use KC_LCAP, KC_LNUM or KC_LSCR instead in keymap */
#define LOCKING_SUPPORT_ENABLE

Expand Down
3 changes: 3 additions & 0 deletions keyboards/halokeys/elemental75/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
{"pin_a": "B6", "pin_b": "B5"}
]
},
"tapping": {
"term": 300
},
"ws2812": {
"pin": "A10"
},
Expand Down
3 changes: 0 additions & 3 deletions keyboards/handwired/2x5keypad/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,3 @@

/* Locking resynchronize hack */
#define LOCKING_RESYNC_ENABLE

/* Tap dancing params */
#define TAPPING_TERM 250
3 changes: 3 additions & 0 deletions keyboards/handwired/2x5keypad/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"pid": "0x2020",
"device_version": "0.0.1"
},
"tapping": {
"term": 250
},
"matrix_pins": {
"cols": ["D4", "C6", "D7", "E6", "B4"],
"rows": ["B3", "B2"]
Expand Down
3 changes: 0 additions & 3 deletions keyboards/handwired/3dp660/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#pragma once


#define TAPPING_TERM 400

/* Mechanical locking support. Use KC_LCAP, KC_LNUM or KC_LSCR instead in keymap */
#define LOCKING_SUPPORT_ENABLE
/* Locking resynchronize hack */
Expand Down
3 changes: 3 additions & 0 deletions keyboards/handwired/3dp660/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"pid": "0x3660",
"device_version": "0.0.1"
},
"tapping": {
"term": 400
},
"matrix_pins": {
"cols": ["D2", "D3", "C6", "C7", "D5", "D4", "D7", "B4", "B5", "B6", "F7", "F6", "F5", "F4", "F1"],
"rows": ["B0", "B1", "B2", "B3", "B7"]
Expand Down
2 changes: 0 additions & 2 deletions keyboards/handwired/42/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@
#define LOCKING_SUPPORT_ENABLE
/* Locking resynchronize hack */
#define LOCKING_RESYNC_ENABLE

#define TAPPING_TERM 100
3 changes: 3 additions & 0 deletions keyboards/handwired/42/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"pid": "0x0000",
"device_version": "0.0.3"
},
"tapping": {
"term": 100
},
"matrix_pins": {
"cols": ["F5", "F6", "F7", "F0", "F1", "F4", "B6", "B5", "D7", "C7", "D6", "B7"],
"rows": ["D2", "D3", "D0", "D1"]
Expand Down
3 changes: 0 additions & 3 deletions keyboards/handwired/aek64/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,3 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define RCPC_KEYS KC_RCTL, KC_TRNS, KC_PGDN
#define LSPO_KEYS KC_LSFT, KC_TRNS, KC_HOME
#define LCPO_KEYS KC_LCTL, KC_TRNS, KC_END

/* Enable double tab */
#define TAPPING_TERM 175
3 changes: 3 additions & 0 deletions keyboards/handwired/aek64/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
"levels": 5,
"breathing": true
},
"tapping": {
"term": 175
},
"processor": "at90usb1286",
"bootloader": "halfkay",
"layouts": {
Expand Down
1 change: 0 additions & 1 deletion keyboards/handwired/ergocheap/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#pragma once

#define TAPPING_TERM 500
#define PERMISSIVE_HOLD

/*
Expand Down
3 changes: 3 additions & 0 deletions keyboards/handwired/ergocheap/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"pid": "0x6942",
"device_version": "0.0.1"
},
"tapping": {
"term": 500
},
"matrix_pins": {
"cols": ["A8", "A9", "B14", "B12", "B13", "B15", "B3", "B11", "A4", "A5", "A6", "A7", "B0", "B1", "B10"],
"rows": ["B5", "B6", "B7", "B9", "B8"]
Expand Down
3 changes: 0 additions & 3 deletions keyboards/handwired/k_numpad17/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#pragma once


#define TAPPING_TERM 400

/* Mechanical locking support. Use KC_LCAP, KC_LNUM or KC_LSCR instead in keymap */
#define LOCKING_SUPPORT_ENABLE
/* Locking resynchronize hack */
Expand Down
3 changes: 3 additions & 0 deletions keyboards/handwired/k_numpad17/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"pid": "0x6060",
"device_version": "0.0.1"
},
"tapping": {
"term": 400
},
"matrix_pins": {
"cols": ["B2", "B1", "F6", "F4"],
"rows": ["D1", "D4", "C6", "D7", "E6"]
Expand Down
1 change: 0 additions & 1 deletion keyboards/handwired/onekey/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
/* Locking resynchronize hack */
#define LOCKING_RESYNC_ENABLE

#define TAPPING_TERM 500
#define PERMISSIVE_HOLD

/*
Expand Down
3 changes: 3 additions & 0 deletions keyboards/handwired/onekey/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
"pid": "0x6465",
"device_version": "0.0.1"
},
"tapping": {
"term": 500
},
"diode_direction": "COL2ROW",
"features": {
"bootmagic": false,
Expand Down
2 changes: 0 additions & 2 deletions keyboards/handwired/riblee_f401/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,3 @@
#pragma once

#define MOUSEKEY_INTERVAL 32

#define TAPPING_TERM 175
3 changes: 3 additions & 0 deletions keyboards/handwired/riblee_f401/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"pid": "0x002A",
"device_version": "0.0.1"
},
"tapping": {
"term": 175
},
"matrix_pins": {
"cols": ["B10", "B1", "B0", "B15", "A8", "B3", "B4", "B5", "B6", "B7", "B8", "B9"],
"rows": ["A6", "A5", "A4", "A3", "A2"]
Expand Down
2 changes: 0 additions & 2 deletions keyboards/handwired/riblee_f411/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,3 @@
#pragma once

#define MOUSEKEY_INTERVAL 32

#define TAPPING_TERM 175
3 changes: 3 additions & 0 deletions keyboards/handwired/riblee_f411/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"pid": "0x002B",
"device_version": "0.0.1"
},
"tapping": {
"term": 175
},
"matrix_pins": {
"cols": ["B10", "B1", "B0", "B15", "A8", "B3", "B4", "B5", "B14", "A0", "B8", "B9"],
"rows": ["A6", "A5", "A4", "A3", "A2"]
Expand Down
3 changes: 0 additions & 3 deletions keyboards/handwired/terminus_mini/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#pragma once

//define maximum duration of hold required to register a tap vs hold default is 200
#define TAPPING_TERM 150 //reduce time required to register a held key

/* Mechanical locking support. Use KC_LCAP, KC_LNUM or KC_LSCR instead in keymap */
#define LOCKING_SUPPORT_ENABLE
/* Locking resynchronize hack */
Expand Down
3 changes: 3 additions & 0 deletions keyboards/handwired/terminus_mini/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"pid": "0x6060",
"device_version": "0.0.1"
},
"tapping": {
"term": 150
},
"matrix_pins": {
"cols": ["B0", "D0", "D5", "B6", "D4", "C7", "F7", "F6", "F5", "F4", "F1", "F0"],
"rows": ["B5", "B4", "D7", "D6"]
Expand Down
2 changes: 0 additions & 2 deletions keyboards/handwired/twig/twig50/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@

#pragma once

#define TAPPING_TERM 150

#ifdef AUDIO_ENABLE
#define AUDIO_PIN A5
#define AUDIO_PIN_ALT A4
Expand Down
3 changes: 3 additions & 0 deletions keyboards/handwired/twig/twig50/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
"device_version": "0.2.1",
"force_nkro": true
},
"tapping": {
"term": 150
},
"matrix_pins": {
"cols": ["A2", "A1", "A0", "B8", "B13", "B14", "B15", "B9", "B10", "B11", "B3", "B2", "B1", "B0"],
"rows": ["B7", "B6", "B5", "B4"]
Expand Down
Loading