Remove use of __flash within LED drivers #21343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
approved these changes
Jun 22, 2023
zvecr
force-pushed
the
feature/flash2progmem2
branch
from
89d5c2d
to
cef0608
Compare
zvecr
changed the title
sigprof
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
The code looks correct, but there is no easy way to even compile test it:
is31fl3733-simple.cis not even referenced inbuilddefs/common_features.mk(theIS31FL3733driver is listed as “TODO” for LED Matrix);is31flcommon.cis hooked up for bothLED_MATRIX_DRIVERandRGB_MATRIX_DRIVER, but there are no keyboards in the repo which specify any of the corresponding values.
drashna
approved these changes
Jun 23, 2023
14 tasks
JohnAZoidberg
added a commit
to JohnAZoidberg/qmk_firmware
that referenced
this pull request
Aug 9, 2023
Need to wait for PR qmk#21343 to hit master. Signed-off-by: Daniel Schaefer <dhs@frame.work>
jesperhellberg
pushed a commit
to jesperhellberg/qmk_firmware
that referenced
this pull request
Sep 9, 2023
thismarvin
pushed a commit
to thismarvin/qmk_firmware
that referenced
this pull request
Sep 27, 2023
akeep
pushed a commit
to akeep/qmk_firmware
that referenced
this pull request
Oct 2, 2023
csolje
pushed a commit
to csolje/qmk_firmware
that referenced
this pull request
Oct 21, 2023
jashort
pushed a commit
to jashort/qmk_firmware
that referenced
this pull request
Nov 20, 2023
autoferrit
pushed a commit
to SpaceRockMedia/bastardkb-qmk
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shouldnt be here due to #15268.
Not sure how this has slipped through for so long, however this aligns everything to the other drivers.
Types of Changes
Issues Fixed or Closed by This PR
Checklist