Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of __flash within LED drivers #21343

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jun 22, 2023

Description

Shouldnt be here due to #15268.

Not sure how this has slipped through for so long, however this aligns everything to the other drivers.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the title Remove use of __flash with LED drivers Remove use of __flash within LED drivers Jun 22, 2023
Copy link
Contributor

@sigprof sigprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks correct, but there is no easy way to even compile test it:

  • is31fl3733-simple.c is not even referenced in builddefs/common_features.mk (the IS31FL3733 driver is listed as “TODO” for LED Matrix);
  • is31flcommon.c is hooked up for both LED_MATRIX_DRIVER and RGB_MATRIX_DRIVER, but there are no keyboards in the repo which specify any of the corresponding values.

@zvecr zvecr merged commit 3156cf6 into develop Jun 23, 2023
@fauxpark fauxpark deleted the feature/flash2progmem2 branch June 23, 2023 21:53
@sigprof sigprof mentioned this pull request Jul 6, 2023
14 tasks
JohnAZoidberg added a commit to JohnAZoidberg/qmk_firmware that referenced this pull request Aug 9, 2023
Need to wait for PR qmk#21343 to hit master.

Signed-off-by: Daniel Schaefer <dhs@frame.work>
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
jashort pushed a commit to jashort/qmk_firmware that referenced this pull request Nov 20, 2023
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants