Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ili9xxx inversion opcode entry #21422

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fix ili9xxx inversion opcode entry #21422

merged 1 commit into from
Jul 3, 2023

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 1, 2023

Description

Found error with inversion cmds in ili9xxx opcode list when troubleshooting issue with ili9341 that needs inversion.

Low impact since it's not actually used currently. Verified against datasheets for 9163, 9341, and 9488.

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

  • discord

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from tzarc and a team July 1, 2023 10:36
elpekenin
elpekenin approved these changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@elpekenin elpekenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a, so-far, harmless typo.

@tzarc tzarc merged commit d2fd9e1 into qmk:develop Jul 3, 2023
@drashna drashna deleted the qp/fix_ili_inversion_cmd branch July 4, 2023 07:16
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@drashna @jesperhellberg
Fix ili9xxx inversion opcode entry (qmk#21422)
c48fe75
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@drashna @thismarvin
Fix ili9xxx inversion opcode entry (qmk#21422)
9df4486
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@drashna @akeep
Fix ili9xxx inversion opcode entry (qmk#21422)
9df4858
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@drashna @csolje
Fix ili9xxx inversion opcode entry (qmk#21422)
3236c82
jashort pushed a commit to jashort/qmk_firmware that referenced this pull request Nov 20, 2023
@drashna @jashort
Fix ili9xxx inversion opcode entry (qmk#21422)
4b28805
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@drashna @autoferrit
Fix ili9xxx inversion opcode entry (qmk#21422)
5d7bf06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

@elpekenin elpekenin elpekenin approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drashna @tzarc @fauxpark @elpekenin