Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate backlight drivers #21444

Merged
merged 6 commits into from
Jul 8, 2023
Merged

Relocate backlight drivers #21444

merged 6 commits into from
Jul 8, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jul 4, 2023 •
edited
Loading

Description

  • Moved PWM drivers to platforms/<platform>/drivers and renamed to backlight_pwm
  • Moved timer driver to ChibiOS platform dir
  • Removed quantum.h includes
  • Fixed incorrect PAL mode for ChibiOS PWM driver (should be 2 for B8 on Proton-C; also per docs)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team July 4, 2023 03:01
@fauxpark
Copy link
Member Author

fauxpark commented Jul 4, 2023

CI failure is unrelated.

As for SHA mismatches, there are a ton. Not sure why. I'm expecting some to possibly come from the BACKLIGHT_PAL_MODE default change, but the bulk appear to be AVR boards.

@drashna drashna requested a review from a team July 6, 2023 05:44
@tzarc tzarc merged commit cb23317 into qmk:develop Jul 8, 2023
@fauxpark fauxpark deleted the backlight-driver-organisation branch July 8, 2023 13:13
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@fauxpark @jesperhellberg
Relocate backlight drivers (qmk#21444)
72773f4
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@fauxpark @thismarvin
Relocate backlight drivers (qmk#21444)
2123ddb
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@fauxpark @akeep
Relocate backlight drivers (qmk#21444)
21b98dc
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@fauxpark @csolje
Relocate backlight drivers (qmk#21444)
2469651
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@fauxpark @autoferrit
Relocate backlight drivers (qmk#21444)
9e50209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug core enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @tzarc