Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move redox_w into redox #21448

Merged
merged 22 commits into from
Jan 13, 2024
Merged

Move redox_w into redox #21448

merged 22 commits into from
Jan 13, 2024

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Jul 4, 2023 •
edited
Loading

cc: @mattdibi

Description

Continuing from suggestion of #21045, have merged redox_w into redox dir

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 4, 2023
@dunk2k
Copy link
Contributor Author

dunk2k commented Jul 4, 2023

@mattdibi

Would you be able to give this one a look over/your blessing?

@dunk2k dunk2k marked this pull request as ready for review July 4, 2023 09:38
@drashna drashna requested a review from a team July 6, 2023 05:34
fauxpark
fauxpark requested changes Jul 27, 2023
View reviewed changes
keyboards/redox/rev1/config.h Outdated Show resolved Hide resolved
@dunk2k dunk2k requested a review from fauxpark August 5, 2023 20:45
@github-actions github-actions bot added the dd Data Driven Changes label Oct 6, 2023
@drashna drashna requested a review from a team October 12, 2023 05:32
fauxpark
fauxpark requested changes Dec 20, 2023
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well remove the user keymaps here.

keyboards/redox/wireless/rules.mk Outdated Show resolved Hide resolved
@dunk2k
Copy link
Contributor Author

dunk2k commented Dec 21, 2023

May as well remove the user keymaps here.

fair shout 😊
Implemented as per commit eeb76ba

@dunk2k dunk2k requested a review from fauxpark December 27, 2023 09:34
@drashna drashna merged commit b1ea30c into qmk:develop Jan 13, 2024
3 checks passed
@dunk2k dunk2k deleted the redox_merge branch January 13, 2024 08:18
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@dunk2k @fauxpark @nuess0r
Move redox_w into redox (qmk#21448)
491d65b 
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
dd Data Driven Changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunk2k @drashna @fauxpark