-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Canadian French input locale #21456
Conversation
GitHub Actions pointed out that the generated file had one extra newline compared to what is expected, so I removed it in a second commit, and now the |
* ┌───┬───┬───┬───┬───┬───┬───┬───┬───┬───┬───┬───┬───┬───────┐ | ||
* │ \ │ ± │ @ │ £ │ ¢ │ ¤ │ ¬ │ ¦ │ ² │ ³ │ ¼ │ ½ │ ¾ │ │ | ||
* ├───┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─────┤ | ||
* │ │ │ │ € │ │ │ │ │ │ § │ ¶ │ [ │ ] │ │ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows OSK doesn't have a Euro symbol here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the Euro symbol is a somewhat recent addition to the Canadian French layout — it appears in Windows 10.0.22598.1 (which is apparently a preview release of Windows 11 23H2, released in the Canary channel on 7 April 2023), but does not appear in Windows 10.0.17134.1 (Windows 10 1803). No idea whether that symbol appears there in any proper releases of Windows 10 and Windows 11 — kbdlayout.info does not have any intermediate versions between those two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Euro symbol is indeed not output by AltGr+E on Windows 10 22H2 19045.3155, but KDE has had it for a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it policy to restrict input locale declarations in QMK to only what the most common released versions of Windows can do? If so, I can remove FR_EURO
from the list.
And another commit because I realised that, while I had checked that everything that was in the keymap was emitting the correct keycodes, I had not checked whether everything that should have been there was indeed there. I missed |
Co-authored-by: Ryan <fauxpark@gmail.com>
Thank you for your contribution! |
Hi there. This pull request is still relevant, and I have one outstanding question:
|
Basically, yes, because it's better to have keycodes "omitted" from the headers compared to Windows 11, than to have users complain about the keycodes not working on older versions. Perhaps this could be mitigated with notes in the docs, but I have observed many times already users not seeming to even notice or understand the last three columns of this table. So I have little faith it will do much. |
Right. I have deleted I do notice that the PR Regenerate Files test fails, after using this command: |
data/constants/keycodes/extras/keycodes_canadian_french_0.0.1.hjson
Outdated
Show resolved
Hide resolved
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Description
This pull request introduces the Canadian French input locale, otherwise known as French Canadian or French (Canada), to QMK. This is not the input locale called "Canadian French (Legacy)".
The commit includes declarations in the required .hjson file, the keymap header and the file for use with
SEND_STRING
, as well as the reference to those files in the documentation. Key names start withFC_
for French Canadian; as for their 4-character names, I have reused the names of keys that output the respective characters in any other existing input locale; and I have validated the key labels, keyboard diagrams, keycodes, Shift and AltGr use, as well as the lookup tables for theSEND_STRING
macro. The input locale works on both Linux and Windows using both layers that output each individual key as well as aSEND_STRING
that sends the entire ASCII table.Types of Changes
quantum/keymap_extras
)Issues Fixed or Closed by This PR
Checklist