Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

null ST110R2.1 (SaikouType) basic support with layouts #21623

Merged
merged 6 commits into from
Dec 23, 2023
Merged

null ST110R2.1 (SaikouType) basic support with layouts #21623

merged 6 commits into from
Dec 23, 2023

Conversation

user176176
Copy link
Contributor

Description

Basic support for the [null] SaikouType ST110R2.1 keyboard and supported layouts.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@user176176 user176176 marked this pull request as ready for review July 27, 2023 15:40
@zvecr
Copy link
Member

zvecr commented Jul 27, 2023

In the future, please don't close and open new PRs. The necessary changes can be amended to the existing PR.

zvecr
zvecr requested changes Jul 27, 2023
View reviewed changes
keyboards/null/st110r2/info.json Outdated Show resolved Hide resolved
keyboards/null/st110r2/readme.md Outdated Show resolved Hide resolved
keyboards/null/st110r2/readme.md Outdated Show resolved Hide resolved
user176176 and others added 4 commits July 27, 2023 19:06
@user176176 @zvecr
Compile and flash examples from QMK CLI to Make in keyboards/null/st1…
29933ff 
…10r2/readme.md

Co-authored-by: Joel Challis <git@zvecr.com>
@user176176 @zvecr
Parameters updated and unneeded ones removed in keyboards/null/st110r…
37591b9 
…2/info.json

Co-authored-by: Joel Challis <git@zvecr.com>
@user176176 @zvecr
Update keyboards/null/st110r2/readme.md to include two more ways to g…
643774c 
…et in to bootloader

Co-authored-by: Joel Challis <git@zvecr.com>
Fixed matrix labels in keyboards/null/st110r2/info.json
cade2c9
@user176176 user176176 force-pushed the null-st110r2-basic-support branch from 5293fcf to cade2c9 Compare July 28, 2023 08:59
drashna
drashna reviewed Aug 3, 2023
View reviewed changes
keyboards/null/st110r2/readme.md
Comment on lines +5 to +6
![st110r2_zoom](https://s3.amazonaws.com/null-src/images/posts/nkbm-st110r2/NKBM-ST110r21-both1.png)
![st110r2_full](https://s3.amazonaws.com/null-src/images/posts/nkbm-st110r2/NKBM-ST110r21-both3.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iedally, these should be hosted on a dedicated image hosting site (such as imgur), but I don't think that these should be an issue?

@drashna drashna requested a review from a team August 3, 2023 06:29
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 22, 2023
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Dec 11, 2023
@drashna drashna merged commit 92d7b8c into qmk:develop Dec 23, 2023
3 checks passed
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@user176176 @zvecr @itsjonny96
[Keyboard] null ST110R2.1 (SaikouType) (qmk#21623)
9e6f1aa 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: user176176 <you@example.com>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@user176176 @zvecr @mechlovin
[Keyboard] null ST110R2.1 (SaikouType) (qmk#21623)
92be4e5 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: user176176 <you@example.com>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@user176176 @zvecr @mechlovin
[Keyboard] null ST110R2.1 (SaikouType) (qmk#21623)
95ff3c4 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: user176176 <you@example.com>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@user176176 @zvecr @nuess0r
[Keyboard] null ST110R2.1 (SaikouType) (qmk#21623)
0d281f1 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: user176176 <you@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@user176176 @zvecr @drashna @fauxpark