Add basic support for lpc11uxx #21743
Conversation
|
Changes like this should target the |
There was a problem hiding this comment.
The latest example of adding support for a new MCU is probably #21352; some more updates are needed to add support properly:
data/schemas/keyboard.jsonschema(add the MCU name to the list of allowed names)docs/compatible_microcontrollers.mdkeyboards/handwired/onekey/: add a new onekey board for a suitable development board having that MCUplatforms/chibios/mcu_selection.mk: add the appropriate makefile sectionplatforms/chibios/bootloaders/: probably a new bootloader interface file would be needed thereplatforms/chibios/boards/: you may need to add a new board there with at leastmcuconf.hset up according to the QMK conventions (all peripherals except USB should be disabled by default)
| branch = master | ||
| branch = qmk-develop |
There was a problem hiding this comment.
No need to update this file (submodule updates refer to some specific commits anyway).
lib/chibios
Outdated
There was a problem hiding this comment.
This update looks like a revert for the current state of the develop branch; you should rebase your changes to develop and drop the lib/chibios submodule update.
lib/chibios-contrib
Outdated
There was a problem hiding this comment.
Apparently the develop branch already has the same version of the lib/chibios-contrib submodule; you should rebase your changes to develop and drop this update.
| #if defined(MCU_LPC) | ||
| // GPIO Port 0 | ||
| # define P0_0 PAL_LINE(IOPORT0, 0) |
There was a problem hiding this comment.
This should probably be handled like https://github.com/qmk/qmk_firmware/blob/develop/platforms/chibios/vendors/RP/_pin_defs.h instead of creating a file full of platform ifdefs.
| # define P0_23 PAL_LINE(IOPORT0, 23) | ||
| // GPIO Port 1 |
There was a problem hiding this comment.
Does the whole LPC family have only pins 0…23 on P0, or is that specific to a particular chip in that family?
There was a problem hiding this comment.
The other chips have the same amount or less in that family. It depends on the size of the chip.
Following qmk conventions and adding a handwired board and related so it can compile.
Description
Same as title. This will allow boards to compile for the lpc11uxx series MCUs.
Currently requires qmk-develop branch in ChibiOS-Contrib for ChibiOS/ChibiOS-Contrib#366.
Types of Changes
Issues Fixed or Closed by This PR
Checklist