-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QP] Support for LS0XX displays #21844
base: develop
Are you sure you want to change the base?
Conversation
Regarding the inverted CS pin, after looking through the ChibiOS code I agree that it does not support inverted CS pins in any way at all. Thus, I'm seeing three possible ways to reliably overcome this issue:
|
Yeah, i agree that the hardware solution is probably the best (and also easiest to handle) one. Will try and handwire a SMD (the only type i have) transistor + use "regular" SPI code to confirm, but im pretty confident it will work just fine. Will report results once (if) i run a test 😃 |
Now depends on #23699 Note: Added the vtable customization at QP's (not the device's) level because i remember having to do the same with eInk displays, so it will be ready for reusability. However i dont quite like the nothing vs "inverted" naming scheme, ideas are welcome |
Description
Initial support for this family of MIP(memory in display) devices.
I dont really like how the code is integrated right now:
#define SPI_SELECT_MODE SPI_SELECT_MODE_NONE
and setting the pin from the display driverDepends on:
PS: According to drFaustroll's research (reported on Discord server), some of this code may also work for displays manufactured by JDI (also MIP but 3bpp -aka 8 colors- instead of monochrome), maybe it could be refactored (or simply renamed) to reuse it across both families.
Types of Changes
Issues Fixed or Closed by This PR
Checklist