-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: joystick weights #21883
Feature: joystick weights #21883
Conversation
Here I have written blog post how I came up with this: https://blog.ffff.lt/posts/joystick-algorithms/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have any joysticks so can't test, but I don't see anything of concern here.
Hey, I have two more changes related with analog joystick, but they are kind of related to this one: automatically resolving min/max axis values and one change that makes joystick behave slightly differently. Should I wait until this PR gets merged or there are other options? cc: @drashna |
That entirely depends on you. Adding more to it would mean that it's definitely gonna be longer to get approved. But it's merge month, so ... it may not make it anyways. So it's up to you. That said, if this is all for joystick code, I'd say roll it into this PR. |
Hey, I have added two more features to joystick code. Please review again. |
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Joystick weights.
Description
I have played around with different algorithms how joystick should work and found out that default x^2 weighting is not necessary optimal. Therefore I have added possibility for user to override weighting for lever positions.
Types of Changes
Checklist