Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reallocate user/kb keycode ranges from kb_user = 64_448 to 128_384. #21950

Conversation

3araht
Copy link
Contributor

@3araht 3araht commented Sep 8, 2023

Description

I understand the user/kb keycode range has reallocated here from kb_user = 256_256 to 64_448, but I'd like to make a little more room for kb.

Would it be possible to have 128 keycodes for kb block?

I would like to use more than 64 keycodes in the kb block with bandominedoni keyboard(#21919 (comment)).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core dd Data Driven Changes labels Sep 8, 2023
@3araht 3araht changed the title Reallocate user/kb keycode ranges from 64_448 to 128_384. Reallocate user/kb keycode ranges from kb_user = 64_448 to 128_384. Sep 8, 2023
@3araht 3araht mentioned this pull request Sep 8, 2023
14 tasks
@fauxpark
Copy link
Member

fauxpark commented Sep 8, 2023

Why does this need to be done? There needs to be a really good reason for changing keycode values and ranges now, as the process is more complicated than what you've done here.

@3araht
Copy link
Contributor Author

3araht commented Sep 9, 2023

I misunderstood what was suggested here.
I'll drop this.

@3araht 3araht closed this Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core dd Data Driven Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants