Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert adm42 to data driven #22144

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Convert adm42 to data driven #22144

merged 1 commit into from
Sep 28, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 26, 2023 •
edited
Loading

Description

Convert to DD, fixing...

  • Licence compatibility issues
  • Headers without guards
  • _kb functions at keymap level

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna merged commit da9f894 into develop Sep 28, 2023
3 checks passed
@drashna drashna deleted the fix_adm42 branch September 28, 2023 06:59
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@zvecr @mechlovin
Fix issues with adm42 (qmk#22144)
bd4eb69
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@zvecr @christrotter
Fix issues with adm42 (qmk#22144)
cb69d9e
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@zvecr @zgagnon
Fix issues with adm42 (qmk#22144)
d257de5
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@zvecr
Fix issues with adm42 (qmk#22144)
bd755e7
mute-civilian pushed a commit to mute-civilian/qmk_firmware that referenced this pull request Feb 17, 2024
@zvecr
Fix issues with adm42 (qmk#22144)
a4fff15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@dunk2k dunk2k dunk2k approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @drashna @fauxpark @dunk2k