Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Remove era/klein #22384

Merged
merged 2 commits into from
Dec 5, 2023
Merged

[Keyboard] Remove era/klein #22384

merged 2 commits into from
Dec 5, 2023

Conversation

eerraa
Copy link
Contributor

@eerraa eerraa commented Nov 1, 2023

Remove era/klein

Description

era/klein is deprecated and replaced by era/sirind/klein_sd.
If possible, I would like to clean the era/klein directory.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

era/klein is replaced by sirind/era/klein_sd
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 1, 2023
@zvecr zvecr changed the title [Keyboard] Update era/klein [Keyboard] Remove era/klein Nov 1, 2023
@drashna
Copy link
Member

drashna commented Nov 4, 2023

era/klein is deprecated and replaced by era/sirind/klein_sd.

Could you add an entry to data/mappings/keyboard_aliases.hjson so that existing keymap json files will be redirected to the correct board, and still compile?

Add an entry to data/mappings/keyboard_aliases.hjson
@github-actions github-actions bot added the dd Data Driven Changes label Nov 4, 2023
@eerraa
Copy link
Contributor Author

eerraa commented Nov 4, 2023

@drashna
Thank you for your help.
Does it look like I added an entry to data/mappings/keyboard_aliases.hjson correctly?

@waffle87 waffle87 merged commit 11aa512 into qmk:develop Dec 5, 2023
3 checks passed
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
* Remove era/klein

era/klein is replaced by sirind/era/klein_sd

* Add an entry to data/mappings/keyboard_aliases.hjson

Add an entry to data/mappings/keyboard_aliases.hjson
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
* Remove era/klein

era/klein is replaced by sirind/era/klein_sd

* Add an entry to data/mappings/keyboard_aliases.hjson

Add an entry to data/mappings/keyboard_aliases.hjson
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
* Remove era/klein

era/klein is replaced by sirind/era/klein_sd

* Add an entry to data/mappings/keyboard_aliases.hjson

Add an entry to data/mappings/keyboard_aliases.hjson
@eerraa eerraa deleted the klein_move branch January 23, 2024 19:07
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
* Remove era/klein

era/klein is replaced by sirind/era/klein_sd

* Add an entry to data/mappings/keyboard_aliases.hjson

Add an entry to data/mappings/keyboard_aliases.hjson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dd Data Driven Changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants