Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LED drivers: refactor page selection #22518

Merged
merged 6 commits into from
Dec 4, 2023
Merged

LED drivers: refactor page selection #22518

merged 6 commits into from
Dec 4, 2023

Conversation

fauxpark
Copy link
Member

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 21, 2023 02:53
@drashna drashna requested a review from a team November 29, 2023 02:22
@fauxpark fauxpark merged commit 358bc8e into qmk:develop Dec 4, 2023
4 checks passed
@fauxpark fauxpark deleted the led-drivers-select-page branch December 4, 2023 06:52
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@fauxpark @itsjonny96
LED drivers: refactor page selection (qmk#22518)
847cfbd
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@fauxpark @mechlovin
LED drivers: refactor page selection (qmk#22518)
773f8d0
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@fauxpark @mechlovin
LED drivers: refactor page selection (qmk#22518)
d3fb6a2
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
LED drivers: refactor page selection (qmk#22518)
6484212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna