Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: projectcain/vault35 #22558

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

lesshonor
Copy link
Contributor

Description

  • Data-driven improvements (feature migration, encoder location, locking config)
  • Add the missing all layout.
  • Add encoder mapping to default keymap.
  • There is now an RP2040 version of this keyboard which I plan to submit later—migrate this version to atmega32u4 in anticipation.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Per the PR Checklist:

  • If the keyboard has multiple electrical/switch layouts:
    • include a LAYOUT_all which specifies all possible layout positions in the electrical matrix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team November 29, 2023 00:36
@drashna drashna merged commit 81d601b into qmk:develop Nov 29, 2023
3 checks passed
@lesshonor lesshonor deleted the enhancement/vault35 branch November 29, 2023 02:24
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants