Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename RGBLED_NUM -> RGBLIGHT_LED_COUNT #22570

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Rename RGBLED_NUM -> RGBLIGHT_LED_COUNT #22570

merged 4 commits into from
Dec 12, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Nov 29, 2023 •
edited
Loading

Description

To match the LED/RGB Matrix define.

User keymaps have been updated but not committed as I assume they will all go soon.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement core keyboard keymap documentation via Adds via keymap and/or updates keyboard for via support labels Nov 29, 2023
@fauxpark fauxpark requested a review from a team November 29, 2023 04:22
@github-actions github-actions bot added the dd Data Driven Changes label Nov 29, 2023
@fauxpark fauxpark marked this pull request as ready for review December 5, 2023 22:07
@fauxpark fauxpark merged commit e648155 into qmk:develop Dec 12, 2023
4 of 6 checks passed
@fauxpark fauxpark deleted the rgblight-led-count branch December 12, 2023 04:30
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@fauxpark @itsjonny96
Rename RGBLED_NUM -> RGBLIGHT_LED_COUNT (qmk#22570)
2d9fa98
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@fauxpark @mechlovin
Rename RGBLED_NUM -> RGBLIGHT_LED_COUNT (qmk#22570)
2ea05cb
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@fauxpark @mechlovin
Rename RGBLED_NUM -> RGBLIGHT_LED_COUNT (qmk#22570)
9506825
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
Rename RGBLED_NUM -> RGBLIGHT_LED_COUNT (qmk#22570)
c88a86a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core dd Data Driven Changes documentation enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @dunk2k