Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kikoslab/kl90): Fix firmware to support encoder knobs properly #22649

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix(kikoslab/kl90): Fix firmware to support encoder knobs properly #22649

merged 1 commit into from
Dec 14, 2023

Conversation

IntusFacultas
Copy link
Contributor

Description

Updates the Kikoslab KL90 firmware to properly support encoders configured via "Via"

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 13, 2023
@IntusFacultas IntusFacultas changed the base branch from master to develop December 13, 2023 03:46
zvecr
zvecr requested changes Dec 13, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
keyboards/kikoslab/kl90/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/kikoslab/kl90/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/kikoslab/kl90/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@IntusFacultas IntusFacultas force-pushed the fix/kl-90-encoder-support branch from 519ad9d to c491134 Compare December 13, 2023 19:13
@IntusFacultas IntusFacultas requested a review from zvecr December 13, 2023 20:47
@zvecr zvecr merged commit d3da222 into qmk:develop Dec 14, 2023
3 checks passed
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@IntusFacultas @itsjonny96
kikoslab/kl90: Update firmware to support encoder map (qmk#22649)
7ea22b9
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@IntusFacultas @mechlovin
kikoslab/kl90: Update firmware to support encoder map (qmk#22649)
cdfd140
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@IntusFacultas @mechlovin
kikoslab/kl90: Update firmware to support encoder map (qmk#22649)
9d8f5f6
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@IntusFacultas @nuess0r
kikoslab/kl90: Update firmware to support encoder map (qmk#22649)
9a9d431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 left review comments

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IntusFacultas @drashna @zvecr @waffle87