Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED drivers: misc formatting and typos #22857

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jan 7, 2024

Description

  • Tightened up/normalised formatting
  • Added missing license headers
  • 3218: tweaked set_value()/set_color() to match the rest of the drivers - fixes potential out of bounds
  • 3737: typo in IS31FL3737_CS_PULLDOWN
  • snled27351: fixed wrong dirty flag being used in update_pwm_buffers()
  • Moved some dirty flag assignments inside their checks (as there is no point setting them if it's the same value)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark merged commit bdede8b into qmk:develop Jan 8, 2024
2 of 3 checks passed
@fauxpark fauxpark deleted the led-drivers-formatting branch January 8, 2024 01:24
@fauxpark fauxpark mentioned this pull request Jan 8, 2024
14 tasks
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants