Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LED drivers: change write_pwm_buffer() return type to void #22869

Merged
merged 2 commits into from
Jan 10, 2024
Merged

LED drivers: change write_pwm_buffer() return type to void #22869

merged 2 commits into from
Jan 10, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jan 8, 2024

Description

#22824

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team January 8, 2024 22:04
@fauxpark
Copy link
Member Author

fauxpark commented Jan 9, 2024

CU80 failures in CI are unrelated.

@tzarc tzarc requested a review from a team January 9, 2024 11:41
@fauxpark fauxpark merged commit 7a3183b into qmk:develop Jan 10, 2024
3 of 4 checks passed
@fauxpark fauxpark deleted the led-drivers-write-pwm-buffer-return-void branch January 10, 2024 01:48
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
LED drivers: change write_pwm_buffer() return type to void (qmk#2…
7df601e 
…2869)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @tzarc