Add first support for Protagonist PCBs #22918

Gondolindrim · 2024-01-18T22:11:16Z

Description

Add first support for WiredIn's Protagonist PCBs PRO-S and PRO-H.

Types of Changes

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/wiredin/protagonist/pro_h/mcuconf.h

zvecr · 2024-01-19T12:32:45Z

keyboards/wiredin/protagonist/pro_s/mcuconf.h

+
+#undef STM32_PWM_USE_ADVANCED
+#define STM32_PWM_USE_ADVANCED TRUE
+


Suggested change

#undef STM32_PWM_USE_ADVANCED

#define STM32_PWM_USE_ADVANCED TRUE

Same as with PRO-H, this is needed for the WS2812 complementary output. The PCB uses STM32F411 with WS2812 PWM driver on pin B15

Except STM32_PWM_USE_ADVANCED isnt a thing anymore, and why it is removal is being requested.

However, feel free to point to the ChibiOS code that "requires" this define.

keyboards/wiredin/protagonist/pro_h/info.json

github-actions · 2024-03-05T01:47:37Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions · 2024-05-02T01:48:56Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

dunk2k · 2024-06-12T18:55:01Z

keyboards/wiredin/protagonist/pro_h/info.json

+    },
+    "processor": "STM32F411",
+    "bootloader": "stm32-dfu",
+    "layouts": {


Can I ask what the matrix co-ordinates (e.g. 3, 5) are for the following compatible keys?:

2u Backspace

2.75u Right Shift

dunk2k · 2024-06-12T18:59:01Z

keyboards/wiredin/protagonist/pro_s/info.json

+    },
+    "processor": "STM32F411",
+    "bootloader": "stm32-dfu",
+    "layouts": {


Could I ask what the matrix co-ordinates (e.g. 3, 5) are for the following keys:

2u Backspace

ISO Enter

2.25u/ANSI LShift

2.75u RShift

dunk2k · 2024-06-12T18:59:33Z

keyboards/wiredin/protagonist/pro_h/info.json

Can this file be renamed to keyboard.json

This file should be renamed to keyboard.json

dunk2k · 2024-06-12T18:59:58Z

keyboards/wiredin/protagonist/pro_h/rules.mk

please delete this file in tandem with info.json name change

dunk2k · 2024-06-12T19:00:04Z

keyboards/wiredin/protagonist/pro_s/info.json

Can this file be renamed to keyboard.json

dunk2k · 2024-06-12T19:00:24Z

keyboards/wiredin/protagonist/pro_s/rules.mk

please delete this file in tandem with info.json name change

dunk2k · 2024-06-12T19:01:22Z

keyboards/wiredin/protagonist/readme.md

image of each PCB variant, in this file, would be helpful 🙂

github-actions · 2024-07-28T01:57:33Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

tzarc · 2024-08-26T10:43:53Z

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

drashna

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

drashna · 2024-09-06T06:41:25Z

keyboards/wiredin/protagonist/pro_h/config.h

+#define LOCKING_SUPPORT_ENABLE
+#define LOCKING_RESYNC_ENABLE
+
+#define RGBLIGHT_DEFAULT_MODE RGBLIGHT_MODE_RAINBOW_SWIRL+5


These settings should be moved to keyboard.json/info.json

drashna · 2024-09-06T06:41:41Z

keyboards/wiredin/protagonist/pro_h/info.json

This file should be renamed to keyboard.json

drashna · 2024-09-06T06:42:20Z

keyboards/wiredin/protagonist/pro_s/config.h

+#define LOCKING_SUPPORT_ENABLE
+#define LOCKING_RESYNC_ENABLE
+


Please move to json.

drashna · 2024-09-06T06:42:27Z

keyboards/wiredin/protagonist/pro_s/config.h

+#define BACKLIGHT_PWM_CHANNEL   4
+#define BACKLIGHT_PWM_PAL_MOPDE 2
+
+#define RGBLIGHT_DEFAULT_MODE RGBLIGHT_MODE_RAINBOW_SWIRL+5


drashna · 2024-09-06T06:42:59Z

keyboards/wiredin/protagonist/readme.md

+
+* Keyboard Maintainer: [Gondolindrim](https://github.com/Gondolindrim)
+* Hardware Supported: proprietary PCB using STM32F411 microcontroller;
+* Hardware Availability: the Protagonist is scheduled to enter Group Buy in february 2024.


Could this be updated now.

…tagonist

dunk2k · 2024-10-05T07:58:18Z

keyboards/wiredin/protagonist/pro_h/keyboard.json

Checking Protagonist Extras, could the following Community Layouts be added?:

60_ansi_tsangan

60_ansi_tsangan_split_bs_rshift

60_ansi_wkl

60_ansi_wkl_split_bs_rshift

60_hhkb

dunk2k · 2024-10-05T07:58:37Z

keyboards/wiredin/protagonist/pro_s/keyboard.json

Checking (Protagonist Extras](https://wiredinstore.com/products/protagonist-extras), could the following Community Layouts be added?:

60_ansi_tsangan

60_ansi_tsangan_split_bs_rshift

60_ansi_wkl

60_ansi_wkl_split_bs_rshift

60_hhkb

60_iso_tsangan

60_iso_tsangan_split_bs_rshift

60_iso_wkl

60_iso_wkl_split_bs_rshift

github-actions · 2024-11-20T02:05:14Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions · 2024-12-21T02:01:18Z

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

Add first support for Protagonist PCBs

19ba77a

github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 18, 2024

Gondolindrim marked this pull request as ready for review January 18, 2024 22:16

zvecr requested changes Jan 19, 2024

View reviewed changes

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Mar 5, 2024

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Mar 18, 2024

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label May 2, 2024

Gondolindrim requested a review from zvecr May 13, 2024 02:49

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label May 14, 2024

dunk2k suggested changes Jun 12, 2024

View reviewed changes

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 28, 2024

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Aug 27, 2024

drashna requested changes Sep 6, 2024

View reviewed changes

Gondolindrim added 2 commits September 8, 2024 15:49

Merge branch 'master' of https://github.com/qmk/qmk_firmware into pro…

4f30fb4

…tagonist

Solderable proto testing

557c0bd

Gondolindrim force-pushed the protagonist branch from e574c03 to 557c0bd Compare September 24, 2024 04:38

dunk2k suggested changes Oct 5, 2024

View reviewed changes

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 20, 2024

github-actions bot closed this Dec 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add first support for Protagonist PCBs #22918

Add first support for Protagonist PCBs #22918

Gondolindrim commented Jan 18, 2024

zvecr Jan 19, 2024

Gondolindrim Mar 17, 2024

zvecr Sep 24, 2024

github-actions bot commented Mar 5, 2024

github-actions bot commented May 2, 2024

dunk2k Jun 12, 2024

dunk2k Jun 12, 2024

dunk2k Jun 12, 2024

drashna Sep 6, 2024

dunk2k Jun 12, 2024

dunk2k Jun 12, 2024

dunk2k Jun 12, 2024

dunk2k Jun 12, 2024

github-actions bot commented Jul 28, 2024

tzarc commented Aug 26, 2024

drashna left a comment

drashna Sep 6, 2024

drashna Sep 6, 2024

drashna Sep 6, 2024

drashna Sep 6, 2024

drashna Sep 6, 2024

dunk2k Oct 5, 2024 •

edited

Loading

dunk2k Oct 5, 2024 •

edited

Loading

github-actions bot commented Nov 20, 2024

github-actions bot commented Dec 21, 2024


		#undef STM32_PWM_USE_ADVANCED
		#define STM32_PWM_USE_ADVANCED TRUE

Add first support for Protagonist PCBs #22918

Add first support for Protagonist PCBs #22918

Conversation

Gondolindrim commented Jan 18, 2024

Description

Types of Changes

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Mar 5, 2024

github-actions bot commented May 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 28, 2024

tzarc commented Aug 26, 2024

drashna left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dunk2k Oct 5, 2024 • edited Loading

Choose a reason for hiding this comment

dunk2k Oct 5, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Nov 20, 2024

github-actions bot commented Dec 21, 2024

dunk2k Oct 5, 2024 •

edited

Loading

dunk2k Oct 5, 2024 •

edited

Loading