Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate lighting defaults to info.json #22920

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 19, 2024

Description

Also a few misc migrations, and removal duplicated defaults.

Any RGBLIGHT_DEFAULT_MODE where it is + N cannot be migrated yet.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team February 1, 2024 08:01
@zvecr zvecr force-pushed the migrate_lighting_defaults branch from 2c81055 to 8f44bc1 Compare February 1, 2024 16:49
@zvecr zvecr merged commit 2f37a78 into qmk:develop Feb 1, 2024
1 of 3 checks passed
@zvecr zvecr deleted the migrate_lighting_defaults branch February 1, 2024 18:10
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants